1254305 - addOptions method takes 3 arguments, 4 given

Status: RESOLVED FIXED

(Instantbird Graveyard :: Account manager, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

addOptions takes 3 arguments: https://hg.mozilla.org/comm-central/annotate/874977941872aab3e7a198fa3912d7c73d7e5a85/chat/content/imAccountOptionsHelper.js#l56
> addOptions: function(aIdPrefix, aOptions, aAttributes) {

But here 4 arguments are given: https://hg.mozilla.org/comm-central/rev/2f6efb061544#l3.105
>      accountOptionsHelper.addOptions(this.proto.id + "-", this.getProtoOptions(),
>                                      null, this.prefs);

Comment 1

[Abdelrahman Ahmed [:abdelrahman]]

Attachment: patch

Oh, thanks for discovering that.

Comment 2

[aleth [:aleth]]

Comment on attachment 8728125 [details] [diff] [review]
patch

Review of attachment 8728125 [details] [diff] [review]:
-----------------------------------------------------------------

am-im.js has too many parameters too.

Comment 3

[Abdelrahman Ahmed [:abdelrahman]]

Attachment: patch

Comment 4

[Patrick Cloke [:clokep]]

Thanks! https://hg.mozilla.org/comm-central/rev/5aff4df43e18

Does this need to be uplifted?

Comment 5

[Abdelrahman Ahmed [:abdelrahman]]

(In reply to Patrick Cloke [:clokep] from comment #4)
> Thanks! https://hg.mozilla.org/comm-central/rev/5aff4df43e18
> 
> Does this need to be uplifted?

I do not think so as the method is called in both cases and the order of passed parameters is same so nothing will be passed wrongly.