H264 Video can't be played because the file is corrupt (Windows only)

VERIFIED FIXED in Firefox 48

Status

()

defect
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: epinal99-bugzilla2, Assigned: jya)

Tracking

({regression})

38 Branch
mozilla48
Unspecified
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox48 verified)

Details

Attachments

(1 attachment)

Reporter

Description

3 years ago
+++ This bug was initially created as a clone of Bug #1247592 +++

STR:
Open this video https://bugzilla.mozilla.org/attachment.cgi?id=8726869

Result:
Video can't be played because the file is corrupt.

Regression range:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=9696d1c4b3ba&tochange=986e840a2979

Suspected bug: maybe 
Jean-Yves Avenard — Bug 1130450: Properly handle MP4 with Apple QT extension. r=k17e



General
Complete name                            : out.mp4
Format                                   : MPEG-4
Format profile                           : Base Media / Version 2
Codec ID                                 : mp42
File size                                : 4.57 MiB
Duration                                 : 18s 244ms
Overall bit rate                         : 2 103 Kbps
Encoded date                             : UTC 2016-03-04 18:46:04
Tagged date                              : UTC 2016-03-04 18:46:04
Writing application                      : VirtualDubMod 1.5.10.2 (build 2540/release)

Video
ID                                       : 2
Format                                   : AVC
Format/Info                              : Advanced Video Codec
Format profile                           : High@L2.1
Format settings, CABAC                   : Yes
Format settings, ReFrames                : 3 frames
Format settings, GOP                     : M=1, N=49
Codec ID                                 : avc1
Codec ID/Info                            : Advanced Video Coding
Duration                                 : 18s 244ms
Bit rate                                 : 2 048 Kbps
Width                                    : 528 pixels
Height                                   : 224 pixels
Display aspect ratio                     : 2.35:1
Frame rate mode                          : Variable
Frame rate                               : 25.000 fps
Minimum frame rate                       : 24.510 fps
Maximum frame rate                       : 25.000 fps
Color space                              : YUV
Chroma subsampling                       : 4:2:0
Bit depth                                : 8 bits
Scan type                                : Progressive
Bits/(Pixel*Frame)                       : 0.693
Stream size                              : 4.29 MiB (94%)
Writing library                          : x264 core 130
Encoding settings                        : cabac=1 / ref=3 / deblock=1:0:0 / analyse=0x3:0x113 / me=hex / subme=7 / psy=1 / psy_rd=1.00:0.00 / mixed_ref=1 / me_range=16 / chroma_me=1 / trellis=1 / 8x8dct=1 / cqm=0 / deadzone=21,11 / fast_pskip=1 / chroma_qp_offset=-2 / threads=3 / lookahead_threads=3 / sliced_threads=1 / slices=3 / nr=0 / decimate=1 / interlaced=0 / bluray_compat=0 / constrained_intra=0 / bframes=0 / weightp=2 / keyint=49 / keyint_min=4 / scenecut=40 / intra_refresh=0 / rc_lookahead=0 / rc=cbr / mbtree=0 / bitrate=2048 / ratetol=1.0 / qcomp=0.60 / qpmin=0 / qpmax=69 / qpstep=4 / vbv_maxrate=2048 / vbv_bufsize=1228 / nal_hrd=none / ip_ratio=1.40 / aq=1:1.00
Language                                 : English
Encoded date                             : UTC 2016-03-04 18:46:04
Tagged date                              : UTC 2016-03-04 18:46:04

Audio
ID                                       : 1
Format                                   : AAC
Format/Info                              : Advanced Audio Codec
Format profile                           : LC
Codec ID                                 : 40
Duration                                 : 18s 227ms
Bit rate mode                            : Constant
Bit rate                                 : 127 Kbps
Channel(s)                               : 2 channels
Channel positions                        : Front: L R
Sampling rate                            : 44.1 KHz
Compression mode                         : Lossy
Stream size                              : 283 KiB (6%)
Language                                 : English
Encoded date                             : UTC 2016-03-04 18:46:04
Tagged date                              : UTC 2016-03-04 18:46:04
Assignee

Updated

3 years ago
Assignee: nobody → jyavenard
Assignee

Updated

3 years ago
Flags: needinfo?(jyavenard)
Reporter

Updated

3 years ago
Blocks: 1130450
Keywords: regression
Assignee

Comment 1

3 years ago
WFM in Nightly and 46 on Mac or FFmpeg.
broken on windows
Reporter

Updated

3 years ago
Summary: H264 Video can't be played because the file is corrupt → H264 Video can't be played because the file is corrupt (Windows only)
Assignee

Comment 2

3 years ago
The error is with the first AAC audio frame ; the WMF Audio decoder chokes on it. So it's totally unrelated to the regression range provided above
Assignee

Comment 3

3 years ago
FWIW, reverting Bug 1130450, and this video still can't be played. wondering how we could ever have played this one...
No longer blocks: 1130450
Flags: needinfo?(jyavenard)
Assignee

Comment 4

3 years ago
FWIW, I find this regression range instead https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=9696d1c4b3ba&tochange=360b5f211180

and before revision 9696d1c4b3ba, the video play but there's no audio track.
Assignee

Comment 5

3 years ago
it's this commit that caused the regression
https://hg.mozilla.org/mozilla-central/rev/36a3cbc746f5

bug 1133572.

The only regression is that the audio track was ignored before because the demuxer couldn't demux a frame, following the change it can demux a frame, but the Microsoft WMF AAC decoder can't decode it for some reasons
Blocks: 1133572
Assignee

Comment 6

3 years ago
Some decoders (wmf) will return an error if fed an empty sample.

Review commit: https://reviewboard.mozilla.org/r/38637/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/38637/
Attachment #8727787 - Flags: review?(cpearce)
Comment on attachment 8727787 [details]
MozReview Request: Bug 1254311: [mp4] Ignore empty raw sample. r=cpearce

https://reviewboard.mozilla.org/r/38637/#review35431
Attachment #8727787 - Flags: review?(cpearce) → review+

Comment 9

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2d9cb763754d
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
QA Whiteboard: [good first verify]
I have reproduced this bug with Nightly 47.0a1 (2016-03-07) on Windows 7, 64 Bit!

The Bug's fix is verified on Latest Beta 48.0b5.

Build ID 	20160630123429
User Agent 	Mozilla/5.0 (Windows NT 6.1; WOW64; rv:48.0) Gecko/20100101 Firefox/48.0
QA Whiteboard: [good first verify] → [good first verify][bugday-20160706]

Comment 11

3 years ago
Video works in Firefox 48.0b6. 
OS: OS X Yosemite 10.10.2
Thanks julesmyers2011 for helping.
I managed to reproduce this issue on Firefox 47.0b8 and on Windows 10 x64.
The issue is no longer reproducible on Firefox 48.0b6.
The tests were performed on Windows 10 x64, Ubuntu 16.04 x64 and on Mac OS X 10.10.5.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.