The long description is cut in Marketplace preview area

RESOLVED FIXED

Status

Firefox OS
Gaia::TV
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: cindylee, Assigned: joseph)

Tracking

unspecified
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-b2g:2.5+, b2g-v2.5 affected, b2g-master affected)

Details

(Whiteboard: [ft:conndevices])

Attachments

(2 attachments)

(Reporter)

Description

2 years ago
Created attachment 8727723 [details]
NG.png

[Description]
The long description is cut in Marketplace preview area without scroll bar.

[Test Steps]
1. Launch Apps->Web Apps.
2. Move cursor to focus on an App with long description.
3. Check the preview area.
4. The long description is cut without scroll bar.

[Expected Result]
4. If the description is too long to show, there should be a scroll bar.

[Actual Result]
4. The long description is cut without scroll bar.
Please refer to attachment.

[Note]
This issue is also observed on v2.5.

[Frequency]
5/5

[Build Info]
Environment: 2.6 Simulator
gaia:
https://github.com/mozilla-b2g/gaia/commit/4c8fb6271fc5268fcec2054b3eb7bd620cfb6f74
gecko:
https://hg.mozilla.org/mozilla-central/rev/b6acf4d4fc20431a8ae14bf32cdc6e43a9c0f9ad

Comment 1

2 years ago
[Blocking Requested - why for this release]: description has truncation if text too long
blocking-b2g: --- → 2.5?
Summary: The long description is cut in Marketplace preview area without scroll bar. → The long description is cut in Marketplace preview area

Comment 2

2 years ago
Now we have two contents encounter this issue: "kicker" and "YOUZEEK Free Music"

Updated

2 years ago
Blocks: 1254445

Comment 3

2 years ago
Tori, need your input of how to deal with it. Thanks!
Flags: needinfo?(tchen)

Comment 4

2 years ago
Helen could you take a look on this?
Flags: needinfo?(tchen) → needinfo?(hhuang)

Comment 5

2 years ago
Michael, do you think we can fix this issue by limiting the length of description?
Flags: needinfo?(mellis)
ni Peko. She is the visual owner for Marketplace now. 

Hi Peko, can you take a look at this bug? Thanks!
Flags: needinfo?(hhuang) → needinfo?(pchen)

Comment 7

2 years ago
WE do this currently.   It was my understanding that 430 characters was the maximum length for a description.  This is what we have been communicating to partners. The Kicker description is 428 characters, including spaces.  So, they delivered a description matching our ask. 

@Evelyn - Is 430 not the correct number? Has something changed to alter this?
Flags: needinfo?(mellis) → needinfo?(ehung)
Hi Joseph
Base one the spec,the size for the description area could be fitted 430 characters (6 rows)
Please keep the preview size according to our discussion.
Moreover, the highlight app icon is too big.
Can you help to fix it?
Thanks~
Flags: needinfo?(pchen) → needinfo?(jyeh)

Comment 9

2 years ago
@Peko -  I now know we need to keep descriptions to "6 Rows".  Thanks!  This is new information to me;   this will be helpful information for partners to craft a TV listing that both pleases their team and meets our criteria.

Comment 10

2 years ago
@ Peko - How many Characters can fit on a single row of text?  71? 72? (does it differ by row?)  Please let me know as much information as you are able to share.  This will allow me to help ensure Partners craft listing descriptions that work well with our design.
Flags: needinfo?(pchen)

Comment 11

2 years ago
Peko help answer the question. Thanks!
Assign to Joseph per comment 8.
Assignee: nobody → jyeh
blocking-b2g: 2.5? → 2.5+
Flags: needinfo?(ehung)
Hi Michael,

68 Characters can fit on a single row.
Thanks~
Flags: needinfo?(pchen)

Comment 13

2 years ago
My math is off. Which one of these 3 assumptions is false?

Max = 430 characters
Max = 6 rows
Max = 68 Characters per row. 

But 6 * 68 = 408, so one of these 3 must be wrong.
(Assignee)

Comment 14

2 years ago
Created attachment 8731039 [details] [review]
jostw:josyeh/Marketplace/master/Bug1254432 > mozilla-b2g:master
Flags: needinfo?(jyeh)
(Assignee)

Comment 15

2 years ago
Landed in marketplace-tv-front-end master.

https://github.com/mozilla-b2g/marketplace-tv-front-end/commit/5149fee3a713cf46b8592a47bff6718668938d91


The dev server did not update due to some building failure. See the follow up bug 1257739.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED

Comment 16

2 years ago
@ Peko - Please see comment 13 & provide reply :)
Flags: needinfo?(pchen)
Hi Michael,

Sorry it's my typo.
Please follow
Max = 6 rows
Max = 68 Characters per row.
it would be 6 * 68 = 408
Thanks
Flags: needinfo?(pchen)
You need to log in before you can comment on or make changes to this bug.