1254436 - Improve performance of non-Array dense elements

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect, P3)

Description

[Jan de Mooij [:jandem]]

See https://groups.google.com/d/msg/mozilla.dev.platform/xwTMU7juyVg/IpYlbNK3BAAJ

I looked at the testObjectSingle test. One problem there is that IsDenseElementSetInlineable in IonCaches.cpp checks !obj->is<ArrayObject>(). That seems too strict: I think that code should work for all native objects (without weird Class hooks).

And we're using an IC there because we don't have type information for |a| in IonBuilder, because the code before the loop runs in the interpreter. That's less likely to happen for non-microbenchmark code.

Comment 1

[Tom S. (please needinfo tschuster)]

CacheIR optimizes dense elements on everything not just arrays, can we close this?

Comment 2

[Jan de Mooij [:jandem]]

(In reply to Tom Schuster [:evilpie] from comment #1)
> CacheIR optimizes dense elements on everything not just arrays, can we close
> this?

Yes let's close this one.