1254491 - Let downloadable fonts ride the trains

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

Currently this is behind a Nightly flag.

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

After we have a solution for bug 1250121 we can consider this.

Comment 2

[:Margaret Leibovic]

FYI, we should link this to the Aha! card to track when this will be ready to ship.

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

The patch for bug 1194338 is in the tree. We could enable this everywhere now.

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

There haven't been any follow-up issues. I'll create a patch for enabling this and even uplift to Aurora if no one vetos.

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1254491 - Enable downloadable fonts in all release channels. r?rnewman

Review commit: https://reviewboard.mozilla.org/r/41723/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/41723/

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8733324 [details]
MozReview Request: Bug 1254491 - Enable downloadable fonts in all release channels. r?rnewman

r+ from richard via vidyo mobile weekly meeting :)

Comment 7

[Sebastian Kaspari (:sebastian; :pocmo)]

https://hg.mozilla.org/integration/fx-team/rev/5fc1fd1e170e9a99324a76dd308f53441bf03bd3
Bug 1254491 - Enable downloadable fonts in all release channels. r=rnewman

Comment 8

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8733324 [details]
MozReview Request: Bug 1254491 - Enable downloadable fonts in all release channels. r?rnewman

Approval Request Comment

[Feature/regressing bug #]: Downloadable fonts has been behind a Nightly flag for a month now (bug 1233799). The Nightly APK has been ~6.4% / ~2.7MB smaller since then. Now we would like to enable this for all channels (Code is in 47).

[User impact if declined]: Users shouldn't really see a difference - except that the APK is smaller with this enabled.

[Describe test coverage new/current, TreeHerder]: We had this in Nightly for a month now.

[Risks and why]: Low: This has been in Nightly for a month and there has been only a minor issue (bug 1250121) that is fixed since a week ago. Additionally this was already enabled in Nightly 47, so I do not expect new problems in Aurora 47 now.

[String/UUID change made/needed]: -

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5fc1fd1e170e

Comment 10

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8733324 [details]
MozReview Request: Bug 1254491 - Enable downloadable fonts in all release channels. r?rnewman

On the roadmap for  47 and has baked in Nightly for 4 weeks. Aurora47+

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d4cd004b67f4