1254507 - ASAN Leak in webrtc::DesktopDeviceInfoImpl::RefreshApplicationList()

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Gian-Carlo Pascutto [:gcp]]

Attachment: leak.txt

Current m-c with ASAN running the dom/media mochitests:

==19331==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 616 byte(s) in 20 object(s) allocated from:
    #0 0x4e7080 in operator new[](unsigned long) /home/morbo/svn/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:64
    #1 0x7f0f4eba242b in webrtc::SetStringMember(char**, char const*) /home/morbo/hg/mozilla-central/media/webrtc/trunk/webrtc/modules/desktop_capture/desktop_device_info.cc:27:18
    #2 0x7f0f4eba242b in webrtc::DesktopApplication::setProcessAppName(char const*) /home/morbo/hg/mozilla-central/media/webrtc/trunk/webrtc/modules/desktop_capture/desktop_device_info.cc:114
    #3 0x7f0f4ebb5f6b in webrtc::DesktopDeviceInfoX11::InitializeApplicationList() /home/morbo/hg/mozilla-central/media/webrtc/trunk/webrtc/modules/desktop_capture/x11/desktop_device_info_x11.cc:131:7
    #4 0x7f0f4eba341b in webrtc::DesktopDeviceInfoImpl::RefreshApplicationList() /home/morbo/hg/mozilla-central/media/webrtc/trunk/webrtc/modules/desktop_capture/desktop_device_info.cc:287:3
    #5 0x7f0f4eba341b in webrtc::DesktopDeviceInfoImpl::Refresh() /home/morbo/hg/mozilla-central/media/webrtc/trunk/webrtc/modules/desktop_capture/desktop_device_info.cc:232
    #6 0x7f0f4ebbd424 in webrtc::ScreenDeviceInfoImpl::Refresh() /home/morbo/hg/mozilla-central/media/webrtc/trunk/webrtc/video_engine/desktop_capture_impl.cc:47:3
    #7 0x7f0f4ec2452e in webrtc::ViEInputManager::NumberOfCaptureDevices() /home/morbo/hg/mozilla-central/media/webrtc/trunk/webrtc/video_engine/vie_input_manager.cc:63:3

Comment 1

[Gian-Carlo Pascutto [:gcp]]

Not the first Leak problem with that code: https://bugzilla.mozilla.org/show_bug.cgi?id=1041369#c33

Comment 2

[Gian-Carlo Pascutto [:gcp]]

Attachment: MozReview Request: Bug 1254507 - Fix leak in WebRTC DesktopApplication class. r?jesup

Review commit: https://reviewboard.mozilla.org/r/38651/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/38651/

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8727811 [details]
MozReview Request: Bug 1254507 - Fix leak in WebRTC DesktopApplication class. r?jesup

https://reviewboard.mozilla.org/r/38651/#review35347

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3ffa45c6352e

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3ffa45c6352e