1254544 - [Sync Tabs Sidebar] Right click options are missing for Sidebar Search

Status: VERIFIED FIXED

(Firefox :: Sync, defect, P2)

Description

[Adrian Florinescu [:aflorinescu]]

Attachment: RclickOptions.jpg

[Affected versions]:
- 47.0a1 (20160307030208)
- 48.0a1 (20160308030418)


[Affected platforms]:
- Mac OS X 
- Ubuntu 14.04 32-bit / 15.04 64-bit
- Windows 10

[Steps to reproduce]:
1. Open FF/View/Sidebar/Synced Tabs.
2. If not logged in to your sync account, login and make sure you have at least a device.
3. In the Synced Tabs search box right click.


[Expected result]:
- The options usually found when right clicking an input text box should be available - same as found in History Sidebar / Search (see attached screenshot)

[Actual result]:
- "Sync now" option is displayed.

[Regression range]:
- No


[Additional notes]:
- Shortcuts are working: e.g. Ctrl+V, Shift+Ins, etc.

Comment 1

[Lina Butler [:lina]]

Attachment: MozReview Request: Bug 1254544 - Show clipboard commands in the synced tabs filter context menu. r=markh

Review commit: https://reviewboard.mozilla.org/r/38785/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/38785/

Comment 2

[Lina Butler [:lina]]

Attachment: Screen Shot 2016-03-08 at 2.26.59 PM.png

Here's a first cut. I don't think it's possible for an HTML element to inherit from an XBL binding; otherwise, I would've just inherited from `input-box`. Is there a way to avoid the duplication?

Comment 3

[Mark Hammond [:markh] [:mhammond]]

(In reply to Kit Cambridge [:kitcambridge] from comment #2)
> Here's a first cut. I don't think it's possible for an HTML element to
> inherit from an XBL binding; otherwise, I would've just inherited from
> `input-box`. Is there a way to avoid the duplication?

Not that I'm aware of - this LGTM.

Comment 4

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8728110 [details]
MozReview Request: Bug 1254544 - Show clipboard commands in the synced tabs filter context menu. r=markh

https://reviewboard.mozilla.org/r/38785/#review35461

Nice! Untested, but it LGTM (it's not clear from your comments whether it all works as is, but if it does, then go for it!)

Comment 5

[Lina Butler [:lina]]

Comment on attachment 8728110 [details]
MozReview Request: Bug 1254544 - Show clipboard commands in the synced tabs filter context menu. r=markh

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/38785/diff/1-2/

Comment 6

[Lina Butler [:lina]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4a492af1f37c

Comment 7

[Lina Butler [:lina]]

Comment on attachment 8728110 [details]
MozReview Request: Bug 1254544 - Show clipboard commands in the synced tabs filter context menu. r=markh

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/38785/diff/2-3/

Comment 8

[Lina Butler [:lina]]

This should take care of the tests: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2ef94a67505a

Comment 9

[Lina Butler [:lina]]

Those failures on Linux are interesting. I can't reproduce on Gnome or Unity running locally, and the screenshot didn't help (http://mozilla-releng-blobs.s3.amazonaws.com/blobs/try/sha512/4b15df34d45e6ef30b8fc399aabb57a2b34a0a7ed15dabfd54979935b977ec00f22c3cd27f36efbe7d4670415468ff3cdefc1603e467e2f54901dad5ef753347 is correct; we only show one item if you right-click a device).

I could just remove the `hidden` checks, but it'd be nice to see that we actually hide unused items correctly.

Comment 10

[Lina Butler [:lina]]

Comment on attachment 8728110 [details]
MozReview Request: Bug 1254544 - Show clipboard commands in the synced tabs filter context menu. r=markh

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/38785/diff/3-4/

Comment 11

[Lina Butler [:lina]]

This is looking better! https://treeherder.mozilla.org/#/jobs?repo=try&revision=5b1269ab3bd3

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/ba9179915fb0

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ba9179915fb0

Comment 14

[Camelia Badau [:cbadau], Release Desktop QA]

Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OS X 10.9.5 using latest Nightly 48.0a1 (buildID: 20160413030239) - right click options are: Undo, Cut, Copy, Paste, Delete, Select All, Sync Now.

Comment 15

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hi Mark, Kit, should we consider uplifting this to Beta47? SV suggested it and I wanted to get your opinion on the risks.

Comment 16

[Lina Butler [:lina]]

It moves the context menu code around, but there are no string changes, and I don't think we've seen regressions on Nightly or Aurora. I'd feel comfortable uplifting this.

Comment 17

[Lina Butler [:lina]]

Comment on attachment 8728110 [details]
MozReview Request: Bug 1254544 - Show clipboard commands in the synced tabs filter context menu. r=markh

Approval Request Comment
[Feature/regressing bug #]: This bug.
[User impact if declined]: UX inconsistency: right-clicking the search box in the Synced Tabs sidebar doesn't show the same options as the bookmarks and history sidebars.
[Describe test coverage new/current, TreeHerder]: The patch includes tests for verifying context menu options, https://treeherder.mozilla.org/#/jobs?repo=try&revision=5b1269ab3bd3
[Risks and why]: Low risk. There is some code churn, but the tests should cover this, and we haven't seen regressions on Aurora or Nightly.
[String/UUID change made/needed]: None.

Comment 18

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8728110 [details]
MozReview Request: Bug 1254544 - Show clipboard commands in the synced tabs filter context menu. r=markh

This has been on Aurora/Nightly 48 for ~6 weeks. Seems safe to uplift to Beta47.

Comment 19

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/65cdd9740966

Comment 20

[Camelia Badau [:cbadau], Release Desktop QA]

Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OS X 10.9.5 using Firefox 47 Beta 7 (buildID: 20160518173344) - right click options are: Undo, Cut, Copy, Paste, Delete, Select All, Sync Now.