Closed Bug 1254544 Opened 4 years ago Closed 4 years ago

[Sync Tabs Sidebar] Right click options are missing for Sidebar Search

Categories

(Firefox :: Sync, defect, P2)

48 Branch
defect

Tracking

()

VERIFIED FIXED
Firefox 48
Tracking Status
firefox47 --- verified
firefox48 --- verified

People

(Reporter: adrian_sv, Assigned: lina)

References

Details

Attachments

(3 files)

Attached image RclickOptions.jpg
[Affected versions]:
- 47.0a1 (20160307030208)
- 48.0a1 (20160308030418)


[Affected platforms]:
- Mac OS X 
- Ubuntu 14.04 32-bit / 15.04 64-bit
- Windows 10

[Steps to reproduce]:
1. Open FF/View/Sidebar/Synced Tabs.
2. If not logged in to your sync account, login and make sure you have at least a device.
3. In the Synced Tabs search box right click.


[Expected result]:
- The options usually found when right clicking an input text box should be available - same as found in History Sidebar / Search (see attached screenshot)

[Actual result]:
- "Sync now" option is displayed.

[Regression range]:
- No


[Additional notes]:
- Shortcuts are working: e.g. Ctrl+V, Shift+Ins, etc.
Blocks: 1239084
Version: 47 Branch → 48 Branch
Assignee: nobody → kcambridge
Status: NEW → ASSIGNED
Flags: firefox-backlog+
Priority: -- → P2
Here's a first cut. I don't think it's possible for an HTML element to inherit from an XBL binding; otherwise, I would've just inherited from `input-box`. Is there a way to avoid the duplication?
(In reply to Kit Cambridge [:kitcambridge] from comment #2)
> Here's a first cut. I don't think it's possible for an HTML element to
> inherit from an XBL binding; otherwise, I would've just inherited from
> `input-box`. Is there a way to avoid the duplication?

Not that I'm aware of - this LGTM.
Comment on attachment 8728110 [details]
MozReview Request: Bug 1254544 - Show clipboard commands in the synced tabs filter context menu. r=markh

https://reviewboard.mozilla.org/r/38785/#review35461

Nice! Untested, but it LGTM (it's not clear from your comments whether it all works as is, but if it does, then go for it!)
Attachment #8728110 - Flags: review?(markh) → review+
Blocks: 1246156
Comment on attachment 8728110 [details]
MozReview Request: Bug 1254544 - Show clipboard commands in the synced tabs filter context menu. r=markh

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/38785/diff/1-2/
Attachment #8728110 - Attachment description: MozReview Request: Bug 1254544 - Show clipboard commands in the synced tabs filter context menu. r?markh → MozReview Request: Bug 1254544 - Show clipboard commands in the synced tabs filter context menu. r=markh
Comment on attachment 8728110 [details]
MozReview Request: Bug 1254544 - Show clipboard commands in the synced tabs filter context menu. r=markh

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/38785/diff/2-3/
Those failures on Linux are interesting. I can't reproduce on Gnome or Unity running locally, and the screenshot didn't help (http://mozilla-releng-blobs.s3.amazonaws.com/blobs/try/sha512/4b15df34d45e6ef30b8fc399aabb57a2b34a0a7ed15dabfd54979935b977ec00f22c3cd27f36efbe7d4670415468ff3cdefc1603e467e2f54901dad5ef753347 is correct; we only show one item if you right-click a device).

I could just remove the `hidden` checks, but it'd be nice to see that we actually hide unused items correctly.
Comment on attachment 8728110 [details]
MozReview Request: Bug 1254544 - Show clipboard commands in the synced tabs filter context menu. r=markh

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/38785/diff/3-4/
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ba9179915fb0
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OS X 10.9.5 using latest Nightly 48.0a1 (buildID: 20160413030239) - right click options are: Undo, Cut, Copy, Paste, Delete, Select All, Sync Now.
Hi Mark, Kit, should we consider uplifting this to Beta47? SV suggested it and I wanted to get your opinion on the risks.
Flags: needinfo?(markh)
Flags: needinfo?(kcambridge)
It moves the context menu code around, but there are no string changes, and I don't think we've seen regressions on Nightly or Aurora. I'd feel comfortable uplifting this.
Flags: needinfo?(kcambridge)
Comment on attachment 8728110 [details]
MozReview Request: Bug 1254544 - Show clipboard commands in the synced tabs filter context menu. r=markh

Approval Request Comment
[Feature/regressing bug #]: This bug.
[User impact if declined]: UX inconsistency: right-clicking the search box in the Synced Tabs sidebar doesn't show the same options as the bookmarks and history sidebars.
[Describe test coverage new/current, TreeHerder]: The patch includes tests for verifying context menu options, https://treeherder.mozilla.org/#/jobs?repo=try&revision=5b1269ab3bd3
[Risks and why]: Low risk. There is some code churn, but the tests should cover this, and we haven't seen regressions on Aurora or Nightly.
[String/UUID change made/needed]: None.
Flags: needinfo?(markh)
Attachment #8728110 - Flags: approval-mozilla-beta?
Comment on attachment 8728110 [details]
MozReview Request: Bug 1254544 - Show clipboard commands in the synced tabs filter context menu. r=markh

This has been on Aurora/Nightly 48 for ~6 weeks. Seems safe to uplift to Beta47.
Attachment #8728110 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OS X 10.9.5 using Firefox 47 Beta 7 (buildID: 20160518173344) - right click options are: Undo, Cut, Copy, Paste, Delete, Select All, Sync Now.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.