Closed Bug 1254558 Opened 4 years ago Closed 3 years ago
Remove about:config preferences only used by the legacy ns
IDownload Manager code
59 bytes, text/x-review-board-request
There are some about:config preferences, like "browser.download.manager.showAlertOnComplete", that are only used by the legacy nsIDownloadManager code and the associated user interface. These should be removed as part of decommissioning nsIDownloadManager.
Assignee: nobody → paolo.mozmail
Status: NEW → ASSIGNED
Priority: -- → P5
Comment on attachment 8864833 [details] Bug 1254558 - Remove about:config preferences only used by the legacy nsIDownloadManager code. https://reviewboard.mozilla.org/r/136520/#review140102 ::: security/manager/ssl/tests/mochitest/mixedcontent/test_bug383369.html (Diff revision 1) > let prefs = Cc["@mozilla.org/preferences-service;1"] > .getService(Ci.nsIPrefService); > let prefBranch = prefs.getBranch("browser.download."); > > - const prefKeys = ["dir", "useDownloadDir", "folderList", > + const prefKeys = ["dir", "useDownloadDir", "folderList"]; > - "manager.closeWhenDone", "manager.showWhenStarting"]; may this test start failing for Seamonkey? It's unclear to me whether they run these tests in automation.
Attachment #8864833 - Flags: review?(mak77) → review+
(In reply to Marco Bonardo [::mak] from comment #2) > may this test start failing for Seamonkey? It's unclear to me whether they > run these tests in automation. I don't know if these tests are run, but SeaMonkey is also migrating to the new Downloads API if I understand correctly.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/98b0328c7909 Remove about:config preferences only used by the legacy nsIDownloadManager code. r=mak
You need to log in before you can comment on or make changes to this bug.