Allow specification of alerting properties in series signature

RESOLVED FIXED

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: wlach, Assigned: wlach)

Tracking

Details

Attachments

(1 attachment)

We should allow the user to tweak alerting thresholds and properties in the series. Specifically:

* Whether we should alert on this series or not, overriding defaults (e.g. in AWFY we want the reverse of the usual behaviour: alert on subtests, don't alert on summaries)
* % threshold for changes (Dromaeo should be higher e.g. see bug 1232270)
* Fore window / back window (for example, we want a much larger window for builds)

We could also possibly allow tweaking the t-threshold for alerting, but I'm not sure if we want to mess with that on the series level. Unless others have strong opinions (and arguments), let's leave that out for now
Duplicate of this bug: 1252990
Comment on attachment 8728674 [details] [review]
[treeherder] wlach:1254595 > mozilla:master

Quite a bit of code here, but most of it is boilerplate.
Attachment #8728674 - Flags: review?(jmaher)
Comment on attachment 8728674 [details] [review]
[treeherder] wlach:1254595 > mozilla:master

a few nits in the PR- please address them or help me understand.
Attachment #8728674 - Flags: review?(jmaher) → review-
Attachment #8728674 - Flags: review-
Comment on attachment 8728674 [details] [review]
[treeherder] wlach:1254595 > mozilla:master

Hey Joel, thanks for the feedback -- it encouraged me to expand testing of this feature, which I think was a good idea. I addressed your feedback in a separate commit, let me know what you think.
Attachment #8728674 - Flags: review?(jmaher)
Comment on attachment 8728674 [details] [review]
[treeherder] wlach:1254595 > mozilla:master

I don't see anything scary here!
Attachment #8728674 - Flags: review?(jmaher) → review+
Keywords: autoland
Keywords: autoland
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.