Closed Bug 1254736 Opened 4 years ago Closed 4 years ago

Do not link to unlinkable nodes in frame component

Categories

(DevTools :: Shared Components, defect, P2)

defect

Tracking

(firefox48 fixed)

RESOLVED FIXED
Firefox 48
Tracking Status
firefox48 --- fixed

People

(Reporter: jsantell, Assigned: jsantell)

References

(Blocks 1 open bug)

Details

(Whiteboard: [btpp-fix-later])

Attachments

(2 files)

We should not attempt to link to `http://self-hosted`, for example, and not display line/column information for frames that don't make sense.
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [btpp-fix-later]
Attached image framecomponent.png
This is what it looks like. Just unstyled spans instead of anchors -- works well, except when the functionDisplayName is also displayed -- since they're styled similarly. Although maybe we just do a large style review of this component once Helen's back
Aside: It would be kinda cool to show the self-hosted source contents when show-gecko-platform-data was set.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4f1ffd113644

Good call on showing self-hosted contents somehow, that sounds sweet.
Attachment #8728689 - Flags: review?(nfitzgerald)
Attachment #8728689 - Flags: review?(nfitzgerald) → review+
Thanks for the tests!
https://hg.mozilla.org/mozilla-central/rev/2e1a666a0c23
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.