1254736 - Do not link to unlinkable nodes in frame component

Status: RESOLVED FIXED

(DevTools :: Shared Components, defect, P2)

Description

[Jordan Santell [:jsantell] [@jsantell]]

We should not attempt to link to `http://self-hosted`, for example, and not display line/column information for frames that don't make sense.

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: framecomponent.png

This is what it looks like. Just unstyled spans instead of anchors -- works well, except when the functionDisplayName is also displayed -- since they're styled similarly. Although maybe we just do a large style review of this component once Helen's back

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Aside: It would be kinda cool to show the self-hosted source contents when show-gecko-platform-data was set.

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1254736-frame.patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4f1ffd113644

Good call on showing self-hosted contents somehow, that sounds sweet.

Comment 4

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Thanks for the tests!

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/2e1a666a0c23

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2e1a666a0c23