1254811 - Suggest the default highlighted button is "Cancel" when closing browser.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV::Browser, defect)

Description

[cindylee]

[Description]
Suggest the default highlighted button is "Cancel" when closing browser.

[Test Steps]
1. Launch Browser
2. Click "Back" button
3. Pop up "Do you want to exit Browser" message with "Cancel" and "OK" buttons
4. Observe the behavior
5. The default highlighted button is "OK".


[Expected Result]
5. Suggest the default highlighted button should be "Cancel".
For "Remove App"/ "Clear All History"/ "Clear Cookies" confirmation dialog, the default highlighted button is "Cancel".
We suggest "exist browser" confirmation dialog should be the same.

[Actual Result]
5. The default highlighted button is "OK".
Please refer to: https://youtu.be/lL8BmVgvetE

[Note] The default highlighted button is "Cancel" in "exist browser" confirmation dialog for v2.5.

[Build Info]
Environment: 2.6 Simulator
gaia:
https://github.com/mozilla-b2g/gaia/commit/5b90c09648798d8d66c4b08f81402b27acf0dc08
gecko:
https://hg.mozilla.org/mozilla-central/rev/05c087337043dd8e71cc27bdb5b9d55fd00aaa26

Comment 1

[Cynthia Tang [:cynthiatang]]

Hi Tori,
Could you please check the design? Thank you

Comment 2

[Tori Chen [:tori]]

Sorry for the late reply.
The UX agree that the default highlight should at "Cancel".

Comment 3

[Tori Chen [:tori]]

Please check latest spec here, thanks!
Addon: https://drive.google.com/folderview?id=0B4dMhI4hp32OY0tfN3JvenhySWs&usp=sharing
Remote control: https://drive.google.com/folderview?id=0B5RN80W56Ga9Qkp1Mm5TTlNMTlE&usp=sharing

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] danhuang1202:1254811_hightlight_cancel_button_when_exit_browser > mozilla-b2g:master

Comment 5

[Dan Huang[:danhuang]]

Attachment: Screen shot of highlight cancel button as default

Hi Tori,

I move the cancel button to the right side in the exit browser dialog, because the default focused cancel button always at the right side on the other kind of dialog in the browser.

Do you think this is proper for UX ?

Comment 6

[Tori Chen [:tori]]

Yes, the focus should at "cancel" as default.

Comment 7

[Dan Huang[:danhuang]]

Comment on attachment 8752440 [details] [review]
[gaia] danhuang1202:1254811_hightlight_cancel_button_when_exit_browser > mozilla-b2g:master

Please help review this patch. This patch update browser exit dialog to BrowserDialog and default the cancel button. Thanks.

Comment 8

[Dan Huang[:danhuang]]

Thanks for the review.
Merge in master: https://github.com/mozilla-b2g/gaia/commit/d9cc10c90fe3f8fa8701b6adb823c563729eb9e2

Comment 9

[Dan Huang[:danhuang]]

Comment on attachment 8752440 [details] [review]
[gaia] danhuang1202:1254811_hightlight_cancel_button_when_exit_browser > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):TV 2.6
[User impact] if declined: not align to UX
[Testing completed]: yes 
[Risk to taking this patch] (and alternatives if risky): None
[String changes made]: None

Comment 10

[Josh Cheng [:josh]]

Comment on attachment 8752440 [details] [review]
[gaia] danhuang1202:1254811_hightlight_cancel_button_when_exit_browser > mozilla-b2g:master

Approve for TV 2.6

Comment 11

[GitHub Autolander Bot]

Attachment: [gaia] danhuang1202:v2.6 > mozilla-b2g:v2.6

Comment 12

[Dan Huang[:danhuang]]

Merge in v2.6: https://github.com/mozilla-b2g/gaia/commit/50a2043ce3cc82f4d332460737e7518512401e08