Closed Bug 1254905 Opened 4 years ago Closed 4 years ago

Android emulators are overloaded by WebRTC video tests

Categories

(Core :: WebRTC, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed
Blocking Flags:

People

(Reporter: drno, Unassigned)

References

Details

Attachments

(1 file)

As indicated in bug 929977 comments 35 - 38 it seems pretty clear that the Android emulators are overloaded with any WebRTC video mochitest.

- getStats shows insanely high droppedFrame values in video mochitests
- disabling all video related mochitests on top of ICE consent freshness makes permafailing M9 green again
- reducing the default video size and sampling rate on top of ICE consent freshness also turns the permafailing M9 group green again https://treeherder.mozilla.org/#/jobs?repo=try&revision=d3ca6840a6b4

I guess the most sensible thing to do here is to come with a solution how we can reduce the default video size only on Android emulator test runs (and maybe also the sampling rate).
Rank: 16
backlog: --- → webrtc/webaudio+
This matches what we did for B2G (lower default video size (and framerate!) for fake streams.  We also reduced audio input rates to <realtime there for debug, but that has some real negative side-effects on tests that look at the audio frequencies.
That is an interesting point with the sampling rate. I just started another try run with only the video size a frames reduced, but sampling rate untouched. I'm pretty sure the sampling rate is not as important as changes to video. But let's see how this goes...

So how can we reduce resolution (and FPS?) on Android within mochitest without touching the production code? Pass in video resolution constraints if running on Android?
(In reply to Nils Ohlmeier [:drno] from comment #3)
> That is an interesting point with the sampling rate. I just started another
> try run with only the video size a frames reduced, but sampling rate
> untouched. I'm pretty sure the sampling rate is not as important as changes
> to video. But let's see how this goes...

Actually, we inserted audio into the graph at 1/10th realtime, and let it underrun.  This may not have helped a ton though.  We could drop it from 32K to 16K easily.

> So how can we reduce resolution (and FPS?) on Android within mochitest
> without touching the production code? Pass in video resolution constraints
> if running on Android?

Use SpecialPowers.pushPrefEnv()
Attachment #8731047 - Flags: review?(rjesup)
Even though this does not solve all problems with the tests on Android my plan is to land this improvement here and tackle the remaining issues separately.
Comment on attachment 8731047 [details]
MozReview Request: Bug 1254905: reduced default video size on Android to 320x240 @ 10 FPS. r=jesup

https://reviewboard.mozilla.org/r/40339/#review36919
Attachment #8731047 - Flags: review?(rjesup) → review+
Comment on attachment 8731047 [details]
MozReview Request: Bug 1254905: reduced default video size on Android to 320x240 @ 10 FPS. r=jesup

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40339/diff/1-2/
Attachment #8731047 - Attachment description: MozReview Request: Bug 1254905: reduced default video size on Android to 320x240 @ 10 FPS → MozReview Request: Bug 1254905: reduced default video size on Android to 320x240 @ 10 FPS. r=jesup
https://hg.mozilla.org/mozilla-central/rev/aa73de576cec
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.