1254960 - Back out bug 1219804 from Aurora 47

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

[Tracking Requested - why for this release]:

I'd like to back out bug 1219804 from Aurora because of some of the regressions (see the bug's dependency tree), most notably those with pending UX needinfo requests: bug 1248617, bug 1248268

Note that the backout removes a l10n string, so I assume we want to land this as soon as possible. Or maybe we should just leave the string there?

Comment 1

[Marco Bonardo [:mak]]

Comment on attachment 8728387 [details] [diff] [review]
patch

Afaik, string removals are not a big deal, a localization can be shipped even if the removed string has not yet been removed, the problem is additions/changes.

Though, I'd not want to confuse localizers, they will see this string disappearing in Aurora 46, and then appearing again in 47 (same entity).
Imo, either we leave the string where it is (nota big deal), or we remove it and also rename the string in Nightly, to reduce the likely of someone being confused.

Comment 2

[Marco Bonardo [:mak]]

sorry, I messed up version numbers, please +1 them (merge day confused me)

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 8728387 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: bug 1219804
[User impact if declined]: see comment 0
[Describe test coverage new/current, TreeHerder]: n/a
[Risks and why]: simple backout, not risky
[String/UUID change made/needed]: removes a string, see previous comments. Please let me know if you prefer keeping the string.

Comment 4

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8728387 [details] [diff] [review]
patch

backout due to regressions, taking it.

Comment 5

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

I don't think this one needs to be tracked, I will check back to make sure it lands.

Comment 6

[Dão Gottwald [:dao]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/79e59014d172

Comment 7

[Francesco Lodolo [:flod]]

For future reference it would have been nicer to leave the string there, especially if the backout only happens on mozilla-aurora.

Strings removal creates noise in dashboards, and it's just messy to deal with for localizers working on both mozilla-aurora and mozilla-central.