1254965 - Remove unused Favicons.getSizedFaviconForPageFromCache()

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Favicon Handling, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

Favicons.getSizedFaviconForPageFromCache() is unused and can be removed:
https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/favicons/Favicons.java#199-211

To start, set up a build environment - you can see the instructions here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_for_Android_build
A "front-end" build is good enough for this bug.

Then, you'll need to create a patch to upload - see
https://wiki.mozilla.org/Mobile/Fennec/Android#Creating_commits_and_submitting_patches

If you need any help, you can reply to this bug, or feel free to message me on IRC - my nick is "sebastian" and you can find me and other helpful folks in #mobile. If you need IRC setup instructions, see https://wiki.mozilla.org/IRC

Comment 1

[cijo]

Attachment: Patch

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8728401 [details] [diff] [review]
Patch

Review of attachment 8728401 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Thank you! :)

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

https://hg.mozilla.org/integration/fx-team/rev/b9b21630405247aef15b9d4430512b1b6a6319de
Bug 1254965 - Remove unused Favicons.getSizedFaviconForPageFromCache(). r=sebastian

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b9b216304052