Closed Bug 1254965 Opened 4 years ago Closed 4 years ago

Remove unused Favicons.getSizedFaviconForPageFromCache()

Categories

(Firefox for Android :: Favicon Handling, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 48
Tracking Status
firefox48 --- fixed

People

(Reporter: sebastian, Assigned: bugzilla, Mentored)

Details

(Whiteboard: [lang=java][good first bug])

Attachments

(1 file)

1.67 KB, patch
sebastian
: review+
Details | Diff | Splinter Review
Favicons.getSizedFaviconForPageFromCache() is unused and can be removed:
https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/favicons/Favicons.java#199-211

To start, set up a build environment - you can see the instructions here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_for_Android_build
A "front-end" build is good enough for this bug.

Then, you'll need to create a patch to upload - see
https://wiki.mozilla.org/Mobile/Fennec/Android#Creating_commits_and_submitting_patches

If you need any help, you can reply to this bug, or feel free to message me on IRC - my nick is "sebastian" and you can find me and other helpful folks in #mobile. If you need IRC setup instructions, see https://wiki.mozilla.org/IRC
Attached patch PatchSplinter Review
Attachment #8728401 - Flags: review?(s.kaspari)
Assignee: nobody → bugzilla
Status: NEW → ASSIGNED
Comment on attachment 8728401 [details] [diff] [review]
Patch

Review of attachment 8728401 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Thank you! :)
Attachment #8728401 - Flags: review?(s.kaspari) → review+
https://hg.mozilla.org/integration/fx-team/rev/b9b21630405247aef15b9d4430512b1b6a6319de
Bug 1254965 - Remove unused Favicons.getSizedFaviconForPageFromCache(). r=sebastian
https://hg.mozilla.org/mozilla-central/rev/b9b216304052
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
You need to log in before you can comment on or make changes to this bug.