First urlbar suggestion shows wrong favicon if bookmarked site changes previous favicon

NEW
Unassigned

Status

()

P3
normal
3 years ago
2 years ago

People

(Reporter: arni2033, Unassigned)

Tracking

(Blocks: 1 bug)

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fxsearch])

Attachments

(2 attachments)

(Reporter)

Description

3 years ago
>>>   My Info:   Win7_64, Nightly 48, 32bit, ID 20160308030418
STR (the easiest way):
1. Create new profile, launch it.
2. Open library, export bookmarks from attached file "bookmarks 1"
3. (!) Copy string "addons.mozilla.org" in clipboard
4. Open new tab, paste the string copied in Step 3 into urlbar.
5. Press Enter. Wait until the site is loaded
6. Open new tab, paste the string copied in Step 3 into urlbar.

AR:
 After Step 4 the first suggestion displays default favicon (kind of expected)
 After Step 6 the first suggestion displays wrong favicon

ER:  
 After Step 6 the first suggestion should display correct favicon
(Reporter)

Comment 1

3 years ago
Created attachment 8728394 [details]
bookmarks 1 - wrong favicon if user had bookmark of a site with previous favicon.html
(Reporter)

Comment 2

3 years ago
Created attachment 8728395 [details]
screenshot 1 - wrong favicon if user had bookmark of a site with previous favicon.png

Updated

2 years ago
Priority: -- → P4
Whiteboard: [fxsearch]
(Reporter)

Updated

2 years ago
Blocks: 1262507
Priority: P4 → P5
(Reporter)

Comment 3

2 years ago
The original issue was that one sites changed their favicons, and urlbar started to show wrong favicon
I tested scenario (comment 0) to test if it's really happens, and it is. Now I have even more examples
of that (i.e. sites like http://mail.yandex.ru and http://google.com changed their favicons), and is't
quite obvious now that the bug does happen.

NI? because the very first prioritization was probably made w/o full understanding of the issue.
Note that I use Nightly 2016-05-26 on daily basis
Flags: needinfo?(adw)
Summary: First urlbar suggestion shows wrong favicon if user created/exported bookmark of a site with previous favicon → First urlbar suggestion shows wrong favicon if bookmarked site changes previous favicon

Comment 4

2 years ago
I'm not sure what's happening here but bumping up the priority is OK with me.

I can't reproduce comment 0.  I get the default favicon after step 4 like you say, but after step 6 I get the green puzzle piece favicon, which looks like the correct current favicon of AMO.

But I don't doubt that Firefox shows an old favicon after a site has changed it.  There are several related issues.  I haven't looked deeply at the favicon service in a long time and I know that Marco has better off-hand insight than me.

* Favicons expire after a certain period of time, so ideally you would see the old favicon at the longest only for that period, assuming you visit the site again so that Firefox can capture the new favicon.

* Ideally when you visit a site, Firefox would detect if its copy of the favicon is different from the site's current favicon.  I don't know off-hand if it does that.

* I don't remember off-hand if the first "heuristic" result chooses its favicon differently from the other results.  Based on UnifiedComplete.js I think it does, at least the code paths are different.  Are the other results using the new favicon?

* I think I remember that favicons are stored per page/URL, not per domain?  i.e., they're annotations corresponding to moz_places IDs.  Again I don't recall off-hand.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(adw)

Updated

2 years ago
Priority: P5 → P4
Priority: P4 → P3
You need to log in before you can comment on or make changes to this bug.