1254983 - Replace toast notification with snackbar when choosing to copy password from doorhanger

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Teodora Vermesan (:TeoVermesan)]

Steps to reproduce:
1. Go to facebook.com and login with: username:test and password:mozilla
2. Remember the login
3. Open facebook.com in a new tab
4. Tap the green lock from the URL Bar
5. Choose "Copy" from "Copy password from test?" doorhanger

Actual results:
- "Password copied to clipboard" toast notification is displayed

Expected results:
- A snackbar should be displayed

Comment 1

[Vishnu (:malayaleecoder)]

Sebastian, I am taking up this bug :)

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Have fun! :)

Comment 3

[Vishnu (:malayaleecoder)]

Attachment: Bug1254983_v1.diff

Sebastian, One issue you might see in this, I think, is the renaming of the strings in android_strings.dtd and strings.xml.in
Do tell me whether I should revert them back :)

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8728625 [details] [diff] [review]
Bug1254983_v1.diff

Review of attachment 8728625 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, let's keep the strings as-is. This will avoid that the translators have to translate this again. We have several *toast* strings that used to be toasts but are snackbars now. :)

Comment 5

[Vishnu (:malayaleecoder)]

Attachment: Bug1254983_v2.diff

Have done the necessary changes. Please take a look :)

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8728956 [details] [diff] [review]
Bug1254983_v2.diff

The patch looks great. But I can't apply it to the current tip. Can you rebase your patch against the latest changes?

> TheSilence:fx-team sebastian$ hg import 'https://bug1254983.bmoattachments.org/attachment.cgi?id=8728956'
> applying https://bug1254983.bmoattachments.org/attachment.cgi?id=8728956
> patching file mobile/android/base/java/org/mozilla/gecko/toolbar/SiteIdentityPopup.java
> Hunk #1 FAILED at 5
> 1 out of 2 hunks FAILED -- saving rejects to file mobile/android/base/java/org/mozilla/gecko/toolbar/SiteIdentityPopup.java.rej
> abort: patch failed to apply


Btw. you only need to set "needinfo" or "review" (In this case "review"). One is enough. :)

Comment 7

[Vishnu (:malayaleecoder)]

Attachment: Bug1254983.diff

Sorry for both NI and review :P
Have a look.

Comment 8

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8729504 [details] [diff] [review]
Bug1254983.diff

Review of attachment 8729504 [details] [diff] [review]:
-----------------------------------------------------------------

The patch looks good. Thank you!

Comment 9

[Sebastian Kaspari (:sebastian; :pocmo)]

https://hg.mozilla.org/integration/fx-team/rev/89bb123e0697907b1658809032245bc422253df0
Bug 1254983 - Replace toast notification with snackbar when choosing to copy password from doorhanger. r=sebastian

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/89bb123e0697

Comment 11

[Teodora Vermesan (:TeoVermesan)]

"Password copied to clipboard" snackbar is displayed, so:
Verified as fixed using:
Device: One A2001 (Android 5.1.1)
Build: Firefox for Android 48.0a1 (2016-03-20)