Closed
Bug 1254984
Opened 7 years ago
Closed 7 years ago
Build experimental text representation of the WebAssembly binary code
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: yury, Assigned: yury)
References
Details
Attachments
(2 files, 7 obsolete files)
6.84 KB,
patch
|
Details | Diff | Splinter Review | |
69.65 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
During debugging it will be useful to show something in text form for the running WebAssembly code. The text format is not finalized yet (https://github.com/WebAssembly/design/blob/master/TextFormat.md), but already can have running Wasm code in the SpiderMonkey. It is expected to have some function that will convert binary code produced by wasmTextToBinary into experimental text form.
Assignee | ||
Comment 1•7 years ago
|
||
Assignee | ||
Comment 2•7 years ago
|
||
Attachment #8728744 -
Attachment is obsolete: true
Assignee | ||
Comment 3•7 years ago
|
||
Attachment #8728762 -
Attachment is obsolete: true
Assignee | ||
Comment 4•7 years ago
|
||
Assignee | ||
Comment 5•7 years ago
|
||
Binary to wast/S-expression format conversion. Parsing logic is based on js/src/asmjs/Wasm.cpp and shall be kept in sync.
Attachment #8729042 -
Attachment is obsolete: true
Attachment #8729277 -
Flags: review?(luke)
Assignee | ||
Comment 6•7 years ago
|
||
Attachment #8729190 -
Attachment is obsolete: true
Assignee | ||
Comment 7•7 years ago
|
||
Fixes some sm style checks -- passing try server https://treeherder.mozilla.org/#/jobs?repo=try&revision=65df4b2773c9
Attachment #8729277 -
Attachment is obsolete: true
Attachment #8729277 -
Flags: review?(luke)
Attachment #8729689 -
Flags: review?(luke)
Assignee | ||
Comment 8•7 years ago
|
||
Attachment #8729281 -
Attachment is obsolete: true
Assignee | ||
Comment 9•7 years ago
|
||
More tests and fixed br_table display https://treeherder.mozilla.org/#/jobs?repo=try&revision=d0dc74fa42f1
Attachment #8729689 -
Attachment is obsolete: true
Attachment #8729689 -
Flags: review?(luke)
Attachment #8729761 -
Flags: review?(luke)
![]() |
||
Comment 10•7 years ago
|
||
Comment on attachment 8729761 [details] [diff] [review] Experimental text representation of WebAssembly binary code Great work busting this out! The tests look good too. The iterator refactoring should reduce the amount of duplication between this and Wasm.cpp. With permission, I'll fix the nits inline and land the patch.
Attachment #8729761 -
Flags: review?(luke) → review+
Comment 12•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3e871f2d5b4b
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•