Closed Bug 1254984 Opened 5 years ago Closed 5 years ago

Build experimental text representation of the WebAssembly binary code

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla48
Tracking Flags:
Tracking Status
firefox48 --- fixed

People

(Reporter: yury, Assigned: yury)

References

Details

Attachments

(2 files, 7 obsolete files)

[integration with bug 1254893] Uses wasm debugger integration to show the source
6.84 KB, patch
Details | Diff | Splinter Review
Experimental text representation of WebAssembly binary code
69.65 KB, patch
luke
: review+
Details | Diff | Splinter Review 
During debugging it will be useful to show something in text form for the running WebAssembly code. The text format is not finalized yet (https://github.com/WebAssembly/design/blob/master/TextFormat.md), but already can have running Wasm code in the SpiderMonkey. It is expected to have some function that will convert binary code produced by wasmTextToBinary into experimental text form.
Attached patch wip1 (obsolete) — — Splinter Review
Attached patch wip2 (obsolete) — — Splinter Review
Attachment #8728744 - Attachment is obsolete: true
Attached patch wip3 (obsolete) — — Splinter Review
Attachment #8728762 - Attachment is obsolete: true
Binary to wast/S-expression format conversion. Parsing logic is based on js/src/asmjs/Wasm.cpp and shall be kept in sync.
Attachment #8729042 - Attachment is obsolete: true
Attachment #8729277 - Flags: review?(luke)
Fixes some sm style checks -- passing try server https://treeherder.mozilla.org/#/jobs?repo=try&revision=65df4b2773c9
Attachment #8729277 - Attachment is obsolete: true
Attachment #8729277 - Flags: review?(luke)
Attachment #8729689 - Flags: review?(luke)
More tests and fixed br_table display

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d0dc74fa42f1
Attachment #8729689 - Attachment is obsolete: true
Attachment #8729689 - Flags: review?(luke)
Attachment #8729761 - Flags: review?(luke)
Comment on attachment 8729761 [details] [diff] [review]
Experimental text representation of WebAssembly binary code

Great work busting this out!  The tests look good too.  The iterator refactoring should reduce the amount of duplication between this and Wasm.cpp.  With permission, I'll fix the nits inline and land the patch.
Attachment #8729761 - Flags: review?(luke) → review+
https://hg.mozilla.org/mozilla-central/rev/3e871f2d5b4b
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox48: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
See Also: → 1274618
You need to log in before you can comment on or make changes to this bug.