1254984 - Build experimental text representation of the WebAssembly binary code

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Yury Delendik (:yury)]

During debugging it will be useful to show something in text form for the running WebAssembly code. The text format is not finalized yet (https://github.com/WebAssembly/design/blob/master/TextFormat.md), but already can have running Wasm code in the SpiderMonkey. It is expected to have some function that will convert binary code produced by wasmTextToBinary into experimental text form.

Comment 1

[Yury Delendik (:yury)]

Attachment: wip1

Comment 2

[Yury Delendik (:yury)]

Attachment: wip2

Comment 3

[Yury Delendik (:yury)]

Attachment: wip3

Comment 4

[Yury Delendik (:yury)]

Attachment: Uses wasm debugger integration to show the source

Comment 5

[Yury Delendik (:yury)]

Attachment: Experimental text representation of WebAssembly binary code

Binary to wast/S-expression format conversion. Parsing logic is based on js/src/asmjs/Wasm.cpp and shall be kept in sync.

Comment 6

[Yury Delendik (:yury)]

Attachment: [integration with bug 1254893] Uses wasm debugger integration to show the source

Comment 7

[Yury Delendik (:yury)]

Attachment: Experimental text representation of WebAssembly binary code

Fixes some sm style checks -- passing try server https://treeherder.mozilla.org/#/jobs?repo=try&revision=65df4b2773c9

Comment 8

[Yury Delendik (:yury)]

Attachment: [integration with bug 1254893] Uses wasm debugger integration to show the source

Comment 9

[Yury Delendik (:yury)]

Attachment: Experimental text representation of WebAssembly binary code

More tests and fixed br_table display

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d0dc74fa42f1

Comment 10

[Luke Wagner [:luke]]

Comment on attachment 8729761 [details] [diff] [review]
Experimental text representation of WebAssembly binary code

Great work busting this out!  The tests look good too.  The iterator refactoring should reduce the amount of duplication between this and Wasm.cpp.  With permission, I'll fix the nits inline and land the patch.

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3e871f2d5b4b

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3e871f2d5b4b