Closed Bug 1254984 Opened 5 years ago Closed 5 years ago
Build experimental text representation of the Web
Assembly binary code
During debugging it will be useful to show something in text form for the running WebAssembly code. The text format is not finalized yet (https://github.com/WebAssembly/design/blob/master/TextFormat.md), but already can have running Wasm code in the SpiderMonkey. It is expected to have some function that will convert binary code produced by wasmTextToBinary into experimental text form.
Binary to wast/S-expression format conversion. Parsing logic is based on js/src/asmjs/Wasm.cpp and shall be kept in sync.
Fixes some sm style checks -- passing try server https://treeherder.mozilla.org/#/jobs?repo=try&revision=65df4b2773c9
More tests and fixed br_table display https://treeherder.mozilla.org/#/jobs?repo=try&revision=d0dc74fa42f1
Comment on attachment 8729761 [details] [diff] [review] Experimental text representation of WebAssembly binary code Great work busting this out! The tests look good too. The iterator refactoring should reduce the amount of duplication between this and Wasm.cpp. With permission, I'll fix the nits inline and land the patch.
Attachment #8729761 - Flags: review?(luke) → review+
You need to log in before you can comment on or make changes to this bug.