Build experimental text representation of the WebAssembly binary code

RESOLVED FIXED in Firefox 48

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: yury, Assigned: yury)

Tracking

Trunk
mozilla48
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed)

Details

Attachments

(2 attachments, 7 obsolete attachments)

Assignee

Description

3 years ago
During debugging it will be useful to show something in text form for the running WebAssembly code. The text format is not finalized yet (https://github.com/WebAssembly/design/blob/master/TextFormat.md), but already can have running Wasm code in the SpiderMonkey. It is expected to have some function that will convert binary code produced by wasmTextToBinary into experimental text form.
Assignee

Comment 1

3 years ago
Posted patch wip1 (obsolete) — Splinter Review
Assignee

Comment 2

3 years ago
Posted patch wip2 (obsolete) — Splinter Review
Attachment #8728744 - Attachment is obsolete: true
Assignee

Comment 3

3 years ago
Posted patch wip3 (obsolete) — Splinter Review
Attachment #8728762 - Attachment is obsolete: true
Assignee

Comment 5

3 years ago
Binary to wast/S-expression format conversion. Parsing logic is based on js/src/asmjs/Wasm.cpp and shall be kept in sync.
Attachment #8729042 - Attachment is obsolete: true
Attachment #8729277 - Flags: review?(luke)
Assignee

Comment 7

3 years ago
Fixes some sm style checks -- passing try server https://treeherder.mozilla.org/#/jobs?repo=try&revision=65df4b2773c9
Attachment #8729277 - Attachment is obsolete: true
Attachment #8729277 - Flags: review?(luke)
Attachment #8729689 - Flags: review?(luke)
Assignee

Comment 9

3 years ago
More tests and fixed br_table display

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d0dc74fa42f1
Attachment #8729689 - Attachment is obsolete: true
Attachment #8729689 - Flags: review?(luke)
Attachment #8729761 - Flags: review?(luke)
Comment on attachment 8729761 [details] [diff] [review]
Experimental text representation of WebAssembly binary code

Great work busting this out!  The tests look good too.  The iterator refactoring should reduce the amount of duplication between this and Wasm.cpp.  With permission, I'll fix the nits inline and land the patch.
Attachment #8729761 - Flags: review?(luke) → review+

Comment 12

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3e871f2d5b4b
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Assignee

Updated

3 years ago
See Also: → 1274618
You need to log in before you can comment on or make changes to this bug.