Closed
Bug 1255036
Opened 8 years ago
Closed 8 years ago
Consider removing getNotInstalled
Categories
(Core Graveyard :: DOM: Apps, defect)
Core Graveyard
DOM: Apps
Tracking
(firefox48 fixed)
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: marco, Assigned: marco)
References
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
8.84 KB,
patch
|
myk
:
review+
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
This function doesn't make sense anymore, it's always returning an empty array because all apps in the registry are launchable now.
Assignee | ||
Comment 1•8 years ago
|
||
What do you think? Can we remove this function from the Apps API?
Flags: needinfo?(myk)
Flags: needinfo?(fabrice)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → mcastelluccio
Status: NEW → ASSIGNED
Assignee | ||
Comment 4•8 years ago
|
||
myk for dom/apps changes, ehsan for the removal of the function from dom/webidl/Apps.webidl.
Attachment #8728918 -
Flags: review?(myk)
Attachment #8728918 -
Flags: review?(ehsan)
Assignee | ||
Comment 5•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c21ee351630f
Assignee | ||
Updated•8 years ago
|
Keywords: dev-doc-needed
Assignee | ||
Comment 6•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=da6c23751119
Updated•8 years ago
|
Attachment #8728918 -
Flags: review?(ehsan) → review+
Updated•8 years ago
|
Attachment #8728918 -
Flags: review?(myk) → review+
Assignee | ||
Comment 7•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=810e8ccd8a84
Assignee | ||
Comment 8•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/3b9f13405a7eabfe51943c3855453447ca8e7789 Bug 1255036 - Remove mozApps::getNotInstalled. r=myk,ehsan
Comment 9•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3b9f13405a7e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Comment 10•8 years ago
|
||
We never ended up documenting this on MDN ;-| I've added a note to the Firefox 48 release notes, just in case: https://developer.mozilla.org/en-US/Firefox/Releases/48#Others
Keywords: dev-doc-needed → dev-doc-complete
Updated•7 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•