1255036 - Consider removing getNotInstalled

Status: RESOLVED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[Marco Castelluccio [:marco]]

This function doesn't make sense anymore, it's always returning an empty array because all apps in the registry are launchable now.

Comment 1

[Marco Castelluccio [:marco]]

What do you think? Can we remove this function from the Apps API?

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Yes, I think we can remove it!

Comment 3

[[:fabrice] Fabrice Desré]

Sure, go ahead.

Comment 4

[Marco Castelluccio [:marco]]

Attachment: remove_getNotInstalled

myk for dom/apps changes, ehsan for the removal of the function from dom/webidl/Apps.webidl.

Comment 5

[Marco Castelluccio [:marco]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c21ee351630f

Comment 6

[Marco Castelluccio [:marco]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=da6c23751119

Comment 7

[Marco Castelluccio [:marco]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=810e8ccd8a84

Comment 8

[Marco Castelluccio [:marco]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3b9f13405a7eabfe51943c3855453447ca8e7789
Bug 1255036 - Remove mozApps::getNotInstalled. r=myk,ehsan

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3b9f13405a7e

Comment 10

[Chris Mills [:cmills]]

We never ended up documenting this on MDN ;-|

I've added a note to the Firefox 48 release notes, just in case:

https://developer.mozilla.org/en-US/Firefox/Releases/48#Others