Closed Bug 1255048 Opened 5 years ago Closed 2 months ago

Use default Quick Search engine icons instead of favicons

Categories

(Firefox for Android Graveyard :: Favicon Handling, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: antlam, Unassigned)

References

()

Details

Attachments

(2 files, 2 obsolete files)

We ship icons for our default search engines. 

If a user has a history item from say, DuckDuckGo, we should just use that icon in the list item rather than try to fetch a new one (which often results in a globe).

Here's what the items would look like.
I thought I remembered a discussion about some technical reason why this isn't possible (or easy), but the world may have changed since then.

I do see that we fixed bug 961600, so now we're using the favicon cache for search engines.

Would it be possible to also grab these icons for items in our home panels?

I think this would be a really nice improvement.
Flags: needinfo?(s.kaspari)
Flags: needinfo?(ahunt)
I haven't looked into this yet and there's still so much other stuff going on. However I would like to grab a bunch of those favicon / topsites bugs in Q2 (depending on other priorities).
Flags: needinfo?(s.kaspari)
Can we get an aha card for this?
Flags: needinfo?(bbermes)
Attached file fennec_qsearch_icons2.zip (obsolete) —
I've noticed that our default favicons have a 4dp corner radius while our current quick search icons have a 2dp corner radius.

Once this bugs land, they'll look pretty out-of-place next to each other. So, let's update those default quick search icons with these too- I made them 4dp so they'll all be the same.
Attached image content-notification-actions.png (obsolete) —
Attachment #8745332 - Flags: feedback?(alam)
Comment on attachment 8745332 [details]
content-notification-actions.png

Wrong bug..
Attachment #8745332 - Attachment is obsolete: true
Attachment #8745332 - Flags: feedback?(alam)
Comment on attachment 8745332 [details]
content-notification-actions.png

Nice!
Attachment #8745332 - Flags: feedback+
No longer blocks: fennec-polish, 1227019
iOS caught some alignment issues so we're updating these to standardize the graphics 

These are good to go.
Attachment #8743369 - Attachment is obsolete: true
This is probably complicated since it would require touching Favicon code (and liable to causing regressions), I'm guessing we don't want to prioritise this right now?

Since we're also generating nicer default favicons in place of the globe, this is probably less of an issue than in the past?
Flags: needinfo?(ahunt)
(In reply to Andrzej Hunt :ahunt from comment #9)
> This is probably complicated since it would require touching Favicon code
> (and liable to causing regressions), I'm guessing we don't want to
> prioritise this right now?

Yep. Especially with the favicon loading bugs (Linked to bug 1265712) it doesn't make sense to add more sources.
Component: General → Favicon Handling
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → INCOMPLETE
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.