1255098 - Pressing the close button on a tab too quickly causes the Browser to enter a frozen/broken state

Status: VERIFIED FIXED

(Firefox for iOS :: General, defect)

Description

[farhanpatel.17]

Attachment: IMG_1706.mov

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/48.0.2564.116 Safari/537.36

Steps to reproduce:

I have a habit of quickly tapping the close button on a tab to close a series of tabs at once. It works well in Safari where when you tap the close button the next tab's close button appears right underneath allowing for you to not have to wait for the animation to finish. I've attached a video. Here is another.
https://www.dropbox.com/s/ardutkaqmwcxnyb/IMG_1707.mov?dl=0



Actual results:

When I try something similar with the firefox browser the app opens a browser tab but with frozen UI. And if the UI does work going to a new url will freeze the UI and the url bar and tab button do not work. Only way to break out of it is to restart the app.


Expected results:

What I'm thinking is happening is because the deletion of the cell happens after the animation finishes. I am actually opening the tab I'm about to close and because of that a bunch of weirdness is happening.

Comment 1

[Aaron Train [:aaronmt]]

Thanks for the report. Trying this out in a simulator now and was able to reproduce. I opened two blanks and quickly closed the first having clicked (using a mouse) multiple times and immediately hit a hang as confirmed by trying to access any UI.

Comment 2

[farhanpatel.17]

Attachment: Pull Request

This fixes the issue. By moving the deletion of the tab before the animation it removes the ability to tap a tab before the deletion animation completes.

Comment 3

[farhanpatel.17]

Comment on attachment 8728545 [details]
Pull Request

https://github.com/mozilla/firefox-ios/pull/1622

Comment 4

[farhanpatel.17]

Comment on attachment 8728545 [details]
Pull Request

>https://github.com/mozilla/firefox-ios/pull/1622

Comment 5

[Stephan Leroux [:sleroux]]

Comment on attachment 8728545 [details]
Pull Request

Looks good just a nit.

Comment 6

[Stephan Leroux [:sleroux]]

master 8ea8d9b169be62395f6a71a7102c5c2d3900b03d

Comment 7

[Stephan Leroux [:sleroux]]

v3.x 63ffb96

Comment 8

[Simon Basca [:SimonB]]

Tested on 3.0(9) and 4.0.0(1)

The application runs correctly when pressing the close button on a tab quickly.