Closed Bug 1255105 Opened 8 years ago Closed 4 years ago

Use SurfacePipe in the BMP decoder

Categories

(Core :: Graphics: ImageLib, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla75
Tracking Status
firefox75 --- fixed

People

(Reporter: seth, Assigned: aosmond)

References

(Blocks 2 open bugs)

Details

(Whiteboard: gfx-noted)

Attachments

(1 file)

SurfacePipe is intended to eliminate the possibility of output buffer overflows in ImageLib, so we want to use it for all decoders. That includes BMP.
Blocks: 1255109

This patch converts the BMP decoder to use SurfacePipe instead of using
AllocateFrame and Downscaler directly. As a result, it now uses the
accelerated premultiplication path, honours the
SurfaceFlags::NO_PREMULTIPLY_ALPHA flag, and allows for a path forward
to support color management and clipboard better.

Assignee: nobody → aosmond
Status: NEW → ASSIGNED
Blocks: 1615395
Attachment #9129956 - Attachment description: Bug 1255105 - Use SurfacePipe in the BMP decoder. r=tnikkel → Bug 1255105 - Use SurfacePipe in the BMP decoder.
Pushed by aosmond@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8b93db4865f2
Use SurfacePipe in the BMP decoder. r=tnikkel
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: