1255167 - Default object arguments are not defined as lexical dependencies.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Stefan Sechelmann]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/49.0.2623.75 Safari/537.36

Steps to reproduce:

Define the following function:
f = function(a){ (function({aa = a}){ console.log('result: ' + aa); })({}); }
invoke it
f(42)


Actual results:

ReferenceError: a is not defined


Expected results:

console log: result: 42

Comment 1

[Tooru Fujisawa [:arai]]

maybe similar issue to bug 1126361

Comment 2

[Morgan Phillips [:mrrrgn]]

The right hand side of the destructuring assignment isn't being added to pc->lexdeps. Adding it will ensure that it is defined in the inner function's scope via Parser::leaveFunction

Coming up with a patch for this in a jiffy.

Comment 3

[Morgan Phillips [:mrrrgn]]

Attachment: lexdeps.diff

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9875b2e0eced

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/095c359e97ad
Default destructuring arguments should show up as lexical dependencies; r=jorendorff

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/095c359e97ad