Closed
Bug 1255173
Opened 9 years ago
Closed 9 years ago
Fix onZoomReset() in test_wheel_default_action.html to work with e10s
Categories
(Core :: DOM: Events, defect)
Core
DOM: Events
Tracking
()
RESOLVED
FIXED
mozilla48
People
(Reporter: mccr8, Assigned: mccr8)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
3.18 KB,
patch
|
masayuki
:
review+
jmaher
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
With this fixed, all of the tests except doTestWholeScroll() work with e10s enabled.
Fixing this requires two things. First, "test.events.async.enabled" must be set to true so we generate key events in the parent process. Second, some SpecialPowers infrastructure must be set up to send "browser-fullZoom:zoomReset" to the child process.
Assignee | ||
Comment 2•9 years ago
|
||
"test.events.async.enabled" must be set to true so we generate key events in the parent process, which is what triggers the zoom reset.
In addition, some SpecialPowers infrastructure must be set up to listen for "browser-fullZoom:zoomReset" in the parent and send it to an observer in the child.
try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ed14a344e2b2
This does not yet enable the test with e10s because there are more remaining failures.
r?masayuki for the window_wheel_default_action.html changes, r?jmaher for the specialpowersAPI.js changes.
Attachment #8728707 -
Flags: review?(masayuki)
Attachment #8728707 -
Flags: review?(jmaher)
Updated•9 years ago
|
Attachment #8728707 -
Flags: review?(masayuki) → review+
Comment 3•9 years ago
|
||
Comment on attachment 8728707 [details] [diff] [review]
Fix onZoomReset() in test_wheel_default_action.html to work with e10s.
Review of attachment 8728707 [details] [diff] [review]:
-----------------------------------------------------------------
thanks for fixing this up!
Attachment #8728707 -
Flags: review?(jmaher) → review+
Updated•9 years ago
|
Blocks: e10s-tests
tracking-e10s:
--- → +
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
Comment 5•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•