Closed Bug 1255204 Opened 4 years ago Closed 4 years ago

Use sentence casing in Settings prefs

Categories

(Firefox for Android :: Settings and Preferences, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 48
Tracking Status
firefox48 --- fixed

People

(Reporter: antlam, Assigned: dineshp, Mentored)

Details

(Whiteboard: [good first bug])

Attachments

(1 file, 1 obsolete file)

After bug 893836, we should stay consistent and carry though to the rest of our Settings.

 - Clear Private Data > Clear private data

Sync
-----
 - Terms of Service > Terms of service
 - Privacy Notice > Privacy notice

Privacy
-----
 - Tracking protection > Tracking Protection
Matej, these were changes that we went over with Michelle but I just wanted to NI again to keep you in the loops. Do you see any issues with these changes?
Flags: needinfo?(matej)
To fix this bug, you'll need to make a change to strings.xml.in and android_strings.dtd. Here's a good example of a similar patch:
http://hg.mozilla.org/mozilla-central/rev/3ec2d772217d
Mentor: margaret.leibovic
Whiteboard: [good first bug]
Attached patch bug1255204.patch (obsolete) — Splinter Review
Made the changes to settings as mentioned.
 - Clear Private Data > Clear private data

Sync
-----
 - Terms of Service > Terms of service
 - Privacy Notice > Privacy notice

Privacy
-----
 - Tracking protection > Tracking Protection

Please verify.
Comment on attachment 8729770 [details] [diff] [review]
bug1255204.patch

Remember to set the reviewer flags, when you want a patch reviewed.
Attachment #8729770 - Flags: review?(margaret.leibovic)
(In reply to Anthony Lam (:antlam) from comment #1)
> Matej, these were changes that we went over with Michelle but I just wanted
> to NI again to keep you in the loops. Do you see any issues with these
> changes?

Yup, looks great to me. Thanks.
Flags: needinfo?(matej)
Assignee: nobody → dpdineshp2
Status: NEW → ASSIGNED
Comment on attachment 8729770 [details] [diff] [review]
bug1255204.patch

Review of attachment 8729770 [details] [diff] [review]:
-----------------------------------------------------------------

This looks great, thanks for the patch!
Attachment #8729770 - Flags: review?(margaret.leibovic) → review+
Keywords: checkin-needed
has problems to apply:

applying bug1255204.patch
patching file mobile/android/base/locales/en-US/sync_strings.dtd
Hunk #1 FAILED at 65
1 out of 2 hunks FAILED -- saving rejects to file mobile/android/base/locales/en-US/sync_strings.dtd.rej
patching file mobile/android/services/strings.xml.in
Hunk #1 FAILED at 48
1 out of 1 hunks FAILED -- saving rejects to file mobile/android/services/strings.xml.in.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh bug1255204.patch
Flags: needinfo?(dpdineshp2)
Attached patch bug1255204.patchSplinter Review
Hi, I created a new patch to fix the bug. The files that this patch modifies are frequently updated, so that is the likely reason for the issues in applying the patch.
Attachment #8729770 - Attachment is obsolete: true
Flags: needinfo?(dpdineshp2)
Attachment #8732597 - Flags: review?(margaret.leibovic)
Attachment #8732597 - Flags: review?(margaret.leibovic) → review+
Keywords: checkin-needed
For future reference, there's no need to update the string identifier when you only change the case.

Case usage and consistency should be an internal matter for each locale: most locales don't have letter/title case, some don't have the concept of uppercase at all.
https://hg.mozilla.org/mozilla-central/rev/cd5db0d77f53
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
(In reply to Francesco Lodolo [:flod] from comment #11)
> For future reference, there's no need to update the string identifier when
> you only change the case.
> 
> Case usage and consistency should be an internal matter for each locale:
> most locales don't have letter/title case, some don't have the concept of
> uppercase at all.

Thanks for the heads up, I'll keep that in mind for the future (there are more of these bugs on file).
You need to log in before you can comment on or make changes to this bug.