1255204 - Use sentence casing in Settings prefs

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Settings and Preferences, defect)

Description

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

After bug 893836, we should stay consistent and carry though to the rest of our Settings.

 - Clear Private Data > Clear private data

Sync
-----
 - Terms of Service > Terms of service
 - Privacy Notice > Privacy notice

Privacy
-----
 - Tracking protection > Tracking Protection

Comment 1

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Matej, these were changes that we went over with Michelle but I just wanted to NI again to keep you in the loops. Do you see any issues with these changes?

Comment 2

[:Margaret Leibovic]

To fix this bug, you'll need to make a change to strings.xml.in and android_strings.dtd. Here's a good example of a similar patch:
http://hg.mozilla.org/mozilla-central/rev/3ec2d772217d

Comment 3

[Dinesh Polathula (:dineshp)]

Attachment: bug1255204.patch

Made the changes to settings as mentioned.

Comment 4

[Dinesh Polathula (:dineshp)]

 - Clear Private Data > Clear private data

Sync
-----
 - Terms of Service > Terms of service
 - Privacy Notice > Privacy notice

Privacy
-----
 - Tracking protection > Tracking Protection

Please verify.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8729770 [details] [diff] [review]
bug1255204.patch

Remember to set the reviewer flags, when you want a patch reviewed.

Comment 6

[Matej Novak [:matej]]

(In reply to Anthony Lam (:antlam) from comment #1)
> Matej, these were changes that we went over with Michelle but I just wanted
> to NI again to keep you in the loops. Do you see any issues with these
> changes?

Yup, looks great to me. Thanks.

Comment 7

[:Margaret Leibovic]

Comment on attachment 8729770 [details] [diff] [review]
bug1255204.patch

Review of attachment 8729770 [details] [diff] [review]:
-----------------------------------------------------------------

This looks great, thanks for the patch!

Comment 8

[Carsten Book [:Tomcat]]

has problems to apply:

applying bug1255204.patch
patching file mobile/android/base/locales/en-US/sync_strings.dtd
Hunk #1 FAILED at 65
1 out of 2 hunks FAILED -- saving rejects to file mobile/android/base/locales/en-US/sync_strings.dtd.rej
patching file mobile/android/services/strings.xml.in
Hunk #1 FAILED at 48
1 out of 1 hunks FAILED -- saving rejects to file mobile/android/services/strings.xml.in.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh bug1255204.patch

Comment 9

[Dinesh Polathula (:dineshp)]

Attachment: bug1255204.patch

Hi, I created a new patch to fix the bug. The files that this patch modifies are frequently updated, so that is the likely reason for the issues in applying the patch.

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/cd5db0d77f53

Comment 11

[Francesco Lodolo [:flod]]

For future reference, there's no need to update the string identifier when you only change the case.

Case usage and consistency should be an internal matter for each locale: most locales don't have letter/title case, some don't have the concept of uppercase at all.

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cd5db0d77f53

Comment 13

[:Margaret Leibovic]

(In reply to Francesco Lodolo [:flod] from comment #11)
> For future reference, there's no need to update the string identifier when
> you only change the case.
> 
> Case usage and consistency should be an internal matter for each locale:
> most locales don't have letter/title case, some don't have the concept of
> uppercase at all.

Thanks for the heads up, I'll keep that in mind for the future (there are more of these bugs on file).