Closed Bug 1255206 Opened 4 years ago Closed 4 years ago
Change and unify mentions of "tap" to "touch"
Another one for the unification and content consistency story. I noticed this in: Advanced > Plugins > Tap to play "Add more search providers" > ...and then tapping the  icon." Accessibility > Magnify small areas > "tapping near them" Not sure if there's anywhere else...
To fix this bug, you'll need to make a change to strings.xml.in and android_strings.dtd. Here's a good example of a similar patch: http://hg.mozilla.org/mozilla-central/rev/3ec2d772217d
Whiteboard: [good first bug]
I replaced the occurrences of tap to touch. Is this the appropriate way to solve the issue?
You should generate a patch for review. To do that, you can follow the directions here: https://developer.mozilla.org/en-US/docs/Mercurial/Using_Mercurial#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F After that, you can request feedback from a reviewer (me, in this case) using the feedback? flag.
I made the required changes, please verify. I tried looking for other occurences of "tap", but I could not find anything relevant that would need to be changed. I pasted the output of a simple 'grep' command which I used to search for mentions of "tap" in https://pastebin.mozilla.org/8864712. If there are any other occurences that I might have overlooked, please let me know.
Attachment #8733755 - Flags: review?(margaret.leibovic)
Comment on attachment 8733755 [details] [diff] [review] bug1255206.patch Review of attachment 8733755 [details] [diff] [review]: ----------------------------------------------------------------- This looks great, thanks!
Attachment #8733755 - Flags: review?(margaret.leibovic) → review+
has problems to apply: adding 1255206 to series file renamed 1255206 -> bug1255206.patch applying bug1255206.patch patching file mobile/android/base/locales/en-US/android_strings.dtd Hunk #1 FAILED at 155 1 out of 3 hunks FAILED -- saving rejects to file mobile/android/base/locales/en-US/android_strings.dtd.rej patch failed, unable to continue (try -v) patch failed, rejects left in working directory errors during apply, please fix and qrefresh bug1255206.patch could you take a look, thanks!
Advanced -> Plugins -> Touch to play Search -> "Add more search providers" -> ...and then touching the  icon." Accessibility -> Magnify small areas -> ...touching near them" verified as fixed using: Device: Nexus 7 (Android 5.1.1) Build: Firefox for Android 48.0a1 (2016-04-05)
You need to log in before you can comment on or make changes to this bug.