1255222 - Use InputConnection#getHandler() to run InputConnection on a separate thread for Android N+

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Keyboards and IME, defect)

Description

[Yohei Yukawa]

Just for a heads up, in Android Framework team I'm working for introducing a new API (it's still an API candidate though) InputConnection#getHandler() for Android N so that application developers can receive InputConnection callbacks on an arbitrary Handler rather than view.getHandler() without unreliable hacks like Bug 835906 and http://crbug.com/551193.

Although the API document is not available online yet, you can download the zip archive from here.
http://developer.android.com/preview/setup-sdk.html#docs-dl

If everything is working as expected you should already be able to use InputConnection#getHandler() with the first Android N developer preview NPC56P.  If you find any issues please feel free to ping me (on this thread).

Thanks!

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

NI Jim or Snorp to comment on this. It would be good to document our needs from such an API.

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Interesting! Yohei, we'll try to look at this, but it may take a while. Thanks for the heads up.

Jim, if you have a chance this might be fun to play with.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

The API looks like it should be straightforward to implement.

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Implement InputConnection.getHandler for Android N (v1)

Implement the new InputConnection.getHandler method for running input
methods on a separate thread in Android N.

Comment 5

[Eugen Sawin [:esawin]]

Comment on attachment 8747949 [details] [diff] [review]
Implement InputConnection.getHandler for Android N (v1)

Review of attachment 8747949 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6b4ca99fc5f5

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6b4ca99fc5f5

Comment 8

[Mike Kaply [:mkaply]]

We're working with a partner and we'd like to get solid Android N support in Firefox 48. Is this something that can be easily uplifted?

Comment 9

[(inactive) Jim Chen [:jchen] [:darchons]]

Yep! It's a fairly trivial patch, but I think it still needs more extensive testing on N. It's also not strictly necessary for N support. Let me know if you want me to go ahead and request uplift.

Comment 10

[Mike Kaply [:mkaply]]

If it doesn't specifically help us on Android N, I wouldn't worry about it.