1255265 - Convert password manager test_notifications.html to browser_capture_doorhanger.js for e10s

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect)

Description

[Matthew N. [:MattN]]

Since this file is testing the browser popup notification implementation it made sense to convert it to a b-c test.

Comment 1

[Matthew N. [:MattN]]

Attachment: MozReview Request: Bug 1255265 - Convert password manager test_notifications.html to browser_capture_doorhanger.js. r=dolske

test_notifications.html was using an <iframe> which is less realistic so I'm using top-level documents.

Review commit: https://reviewboard.mozilla.org/r/39105/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39105/

Comment 2

[Matthew N. [:MattN]]

Attachment: MozReview Request: Bug 1255265 - Rename some helpers and variables in browser_capture_doorhanger.js for clarity. r=dolske

I avoided the renames in the port to b-c to make the interdiff easier.

Review commit: https://reviewboard.mozilla.org/r/39107/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39107/

Comment 3

[Justin Dolske [:Dolske]]

Comment on attachment 8728787 [details]
MozReview Request: Bug 1255265 - Convert password manager test_notifications.html to browser_capture_doorhanger.js. r=dolske

https://reviewboard.mozilla.org/r/39105/#review35989

I'm assuming the guts of the test is a fairly rote conversion from switch/case to add_task, so I didn't look at them individually.

Comment 4

[Justin Dolske [:Dolske]]

Comment on attachment 8728788 [details]
MozReview Request: Bug 1255265 - Rename some helpers and variables in browser_capture_doorhanger.js for clarity. r=dolske

https://reviewboard.mozilla.org/r/39107/#review35991

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/21e02fc102b4

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/5115d7a4ff78

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Backed out for Mac and Windows instances of test_notifications_popup.html timing out after this landed.
https://hg.mozilla.org/integration/fx-team/rev/79256f612a53

https://treeherder.mozilla.org/logviewer.html#?job_id=7947911&repo=fx-team
https://treeherder.mozilla.org/logviewer.html#?job_id=7949564&repo=fx-team

Comment 8

[Matthew N. [:MattN]]

To clarify, this was an intermittent test_notifications_popup.html failure: https://treeherder.mozilla.org/#/jobs?repo=fx-team&fromchange=7e4686be6b1f&filter-searchStr=mochitest%20m(5)&tochange=79256f612a53

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/095be1660e1f

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/095be1660e1f