Closed Bug 1255265 Opened 7 years ago Closed 7 years ago

Convert password manager test_notifications.html to browser_capture_doorhanger.js for e10s

Categories

(Toolkit :: Password Manager, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
e10s + ---
firefox48 --- fixed

People

(Reporter: MattN, Assigned: MattN)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Since this file is testing the browser popup notification implementation it made sense to convert it to a b-c test.
test_notifications.html was using an <iframe> which is less realistic so I'm using top-level documents.

Review commit: https://reviewboard.mozilla.org/r/39105/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39105/
Attachment #8728787 - Flags: review?(dolske)
Comment on attachment 8728787 [details]
MozReview Request: Bug 1255265 - Convert password manager test_notifications.html to browser_capture_doorhanger.js. r=dolske

https://reviewboard.mozilla.org/r/39105/#review35989

I'm assuming the guts of the test is a fairly rote conversion from switch/case to add_task, so I didn't look at them individually.
Attachment #8728787 - Flags: review?(dolske) → review+
Comment on attachment 8728788 [details]
MozReview Request: Bug 1255265 - Rename some helpers and variables in browser_capture_doorhanger.js for clarity. r=dolske

https://reviewboard.mozilla.org/r/39107/#review35991
Attachment #8728788 - Flags: review?(dolske) → review+
https://hg.mozilla.org/mozilla-central/rev/095be1660e1f
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Duplicate of this bug: 479427
You need to log in before you can comment on or make changes to this bug.