1255273 - Partial mar files have two channel IDs

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

Build 7 complete - correct:
$ wget http://bucketlister-delivery.prod.mozaws.net/pub/firefox/candidates/46.0b1-candidates/build7/update/linux-i686/de/firefox-46.0b1.complete.mar
$ mar -T firefox-46.0b1.complete.mar | head
Signature block found with 1 signature
1 additional block found:
  - Product Information Block:
    - MAR channel name: firefox-mozilla-beta
    - Product version: 46.0

Build 7 partial:
$ wget http://bucketlister-delivery.prod.mozaws.net/pub/firefox/candidates/46.0b1-candidates/build7/update/linux-i686/de/firefox-45.0b9-46.0b1.partial.mar
$ mar -T firefox-45.0b9-46.0b1.partial.mar | head
Signature block found with 1 signature
1 additional block found:
  - Product Information Block:
    - MAR channel name: firefox-mozilla-beta,firefox-mozilla-release
    - Product version: 46.0

NB the 2nd last line. The updater may barf if it's expecting a single value there.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

From IRC, this comes from funsize picking up ACCEPTED_MAR_CHANNEL_IDS at
  https://dxr.mozilla.org/mozilla-central/source/release/docker/funsize-update-generator/scripts/funsize.py#212
and that's dual-valued on beta for rc-on-beta
  http://hg.mozilla.org/releases/mozilla-beta/file/default/browser/confvars.sh#l51

Comment 2

[Rail Aliiev [:rail]]

Attachment: pass ACCEPTED_MAR_CHANNEL_IDS for betas

funsize.py patch incoming

Comment 3

[Rail Aliiev [:rail]]

Attachment: MozReview Request: Bug 1255273 - Partial mar files have two channel IDs r=nthomas

Review commit: https://reviewboard.mozilla.org/r/39121/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39121/

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8728786 [details]
MozReview Request: Bug 1255273 - Partial mar files have two channel IDs r=nthomas

https://reviewboard.mozilla.org/r/39121/#review35773

lgtm

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

https://reviewboard.mozilla.org/r/39121/#review35775

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

https://reviewboard.mozilla.org/r/39121/#review35777

Comment 7

[Rail Aliiev [:rail]]

Comment on attachment 8728786 [details]
MozReview Request: Bug 1255273 - Partial mar files have two channel IDs r=nthomas

https://hg.mozilla.org/integration/mozilla-inbound/rev/ec4475ef7e31

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ec4475ef7e31

Comment 9

[Rail Aliiev [:rail]]

Comment on attachment 8728786 [details]
MozReview Request: Bug 1255273 - Partial mar files have two channel IDs r=nthomas

https://hg.mozilla.org/integration/mozilla-inbound/rev/ec4475ef7e31

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ec4475ef7e31

Comment 11

[Rail Aliiev [:rail]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5bbf2e7c2fc6
https://hg.mozilla.org/releases/mozilla-release/rev/970d0cf1c5d9
https://hg.mozilla.org/releases/mozilla-esr45/rev/859cfa4543f9

Comment 12

[Rail Aliiev [:rail]]

To make sure the docker images are the same across the board I ran various hg diff and landed this: https://hg.mozilla.org/releases/mozilla-esr45/rev/21e146bb0e2e