1255374 - Remove unused class BounceAnimatorBuilder

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

BounceAnimatorBuilder is unused:
https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/animation/BounceAnimatorBuilder.java

Remove the file and remove it from moz.build:
https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/moz.build#199



To start, set up a build environment - you can see the instructions here: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_for_Android_build

Then, you'll need to create a patch to upload - see
https://wiki.mozilla.org/Mobile/Fennec/Android#Creating_commits_and_submitting_patches

Comment 1

[Dinesh Polathula (:dineshp)]

Attachment: bug1255374.patch

I removed the file BounceAnimatorBuilder.java and also updated the moz.build file.

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8729523 [details] [diff] [review]
bug1255374.patch

Thank you, Dinesh. I'll review this patch later today.

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8729523 [details] [diff] [review]
bug1255374.patch

Review of attachment 8729523 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Thank you, Dinesh!

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

https://hg.mozilla.org/integration/fx-team/rev/8073490f8fb651c050cde086e1c79cd824610de2
Bug 1255374 - Remove unused class BounceAnimatorBuilder. r=sebastian

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8073490f8fb6