Open Bug 1255415 Opened 8 years ago Updated 3 years ago

Avoid bypassing the DNS cache when using the fetch RequestCache API

Categories

(Core :: Networking, defect, P5)

defect

Tracking

()

People

(Reporter: ehsan.akhgari, Unassigned)

References

Details

(Whiteboard: [necko-backlog])

Attachments

(1 file)

This patch adds a new flag, LOAD_BYPASS_DNS_CACHE to specifically
opt out of the DNS cache, and nothing else, and then adds internal
flags similar to VALIDATE_ALWAYS and LOAD_BYPASS_CACHE but respecting
the DNS cache, and uses them for RequestCache.

The existing behavior of VALIDATE_ALWAYS and LOAD_BYPASS_CACHE is
preserved.
Blocks: 1120715
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Whiteboard: [necko-active]
Comment on attachment 8728980 [details] [diff] [review]
Avoid bypassing the DNS cache when using the fetch RequestCache API

Review of attachment 8728980 [details] [diff] [review]:
-----------------------------------------------------------------

No, this is not the way.  Let's leave the behavior unchanged.  I have to talk to necko folks about next moves and actually figure out if this is that big problem to deal with it first.

::: netwerk/base/nsIRequest.idl
@@ +158,5 @@
> +     *
> +     * NOTE: If you change this value, please update nsICachingChannel constants
> +     * too.
> +     */
> +    const unsigned long LOAD_BYPASS_DNS_CACHE = 1 << 9;

I think we are out of flags here.

and I'm not happy you are moving everything.  if we have space (that I think not) then add to the end.
Attachment #8728980 - Flags: review?(honzab.moz) → review-
OK, then.  Unassigning.
Assignee: ehsan → nobody
Status: ASSIGNED → NEW
honza can you figure out an acceptable formulation - this seems good to have
Assignee: nobody → honzab.moz
Whiteboard: [necko-active] → [necko-backlog]
no intention to work on this soon from me.
Assignee: honzab.moz → nobody
Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258
Priority: -- → P1
Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258
Priority: P1 → P3

Bulk-downgrade of unassigned, >=3 years untouched DOM/Storage bug's priority.

If you have reason to believe this is wrong, please write a comment and ni :jstutte.

Severity: normal → S4
Priority: P3 → P5
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: