1255415 - Avoid bypassing the DNS cache when using the fetch RequestCache API

Status: NEW

(Core :: Networking, defect, P5)

Description

[(no longer active)]

This patch adds a new flag, LOAD_BYPASS_DNS_CACHE to specifically
opt out of the DNS cache, and nothing else, and then adds internal
flags similar to VALIDATE_ALWAYS and LOAD_BYPASS_CACHE but respecting
the DNS cache, and uses them for RequestCache.

The existing behavior of VALIDATE_ALWAYS and LOAD_BYPASS_CACHE is
preserved.

Comment 1

[(no longer active)]

Attachment: Avoid bypassing the DNS cache when using the fetch RequestCache API

Comment 2

[Honza Bambas (:mayhemer)]

Comment on attachment 8728980 [details] [diff] [review]
Avoid bypassing the DNS cache when using the fetch RequestCache API

Review of attachment 8728980 [details] [diff] [review]:
-----------------------------------------------------------------

No, this is not the way.  Let's leave the behavior unchanged.  I have to talk to necko folks about next moves and actually figure out if this is that big problem to deal with it first.

::: netwerk/base/nsIRequest.idl
@@ +158,5 @@
> +     *
> +     * NOTE: If you change this value, please update nsICachingChannel constants
> +     * too.
> +     */
> +    const unsigned long LOAD_BYPASS_DNS_CACHE = 1 << 9;

I think we are out of flags here.

and I'm not happy you are moving everything.  if we have space (that I think not) then add to the end.

Comment 3

[(no longer active)]

OK, then.  Unassigning.

Comment 4

[Patrick McManus [:mcmanus]]

honza can you figure out an acceptable formulation - this seems good to have

Comment 5

[Honza Bambas (:mayhemer)]

no intention to work on this soon from me.

Comment 6

[Firefox Bug Husbandry Bot]

Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258

Comment 7

[Firefox Bug Husbandry Bot]

Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258

Comment 8

[Jens Stutte [:jstutte]]

Bulk-downgrade of unassigned, >=3 years untouched DOM/Storage bug's priority.

If you have reason to believe this is wrong, please write a comment and ni :jstutte.