Closed
Bug 1255562
Opened 8 years ago
Closed 8 years ago
Allow a WebExtension to have an add-on id in mozilla.json
Categories
(Toolkit :: Add-ons Manager, defect)
Toolkit
Add-ons Manager
Tracking
()
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: andy+bugzilla, Assigned: aswan)
Details
(Keywords: dev-doc-needed)
Attachments
(1 file)
This is to allow the add-on id and all other key values not standard to the chrome manifest to be read from a file mozilla.json instead of manifest.json. This will allow the easy porting of applications over from Chrome as per https://wiki.mozilla.org/WebExtensions/Applications It supports: https://github.com/mozilla/addons/issues/61
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → aswan
Iteration: --- → 48.2 - Apr 4
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/42013/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/42013/
Attachment #8733913 -
Flags: review?(dtownsend)
Assignee | ||
Comment 2•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=267b5344807f
Comment 3•8 years ago
|
||
Comment on attachment 8733913 [details] MozReview Request: Bug 1255562 Allow applications property to be in mozilla.json r?mossop https://reviewboard.mozilla.org/r/42013/#review38815 I'm ok with this as-is, but it might be nice to rather than only work for this case to instead be able to merge in any other properties we like, say even if the original has applications.chrome... defined we could still add applciations.gecko...
Attachment #8733913 -
Flags: review?(dtownsend) → review+
Assignee | ||
Comment 4•8 years ago
|
||
Comment on attachment 8733913 [details] MozReview Request: Bug 1255562 Allow applications property to be in mozilla.json r?mossop Review request updated; see interdiff: https://reviewboard.mozilla.org/r/42013/diff/1-2/
Assignee | ||
Comment 5•8 years ago
|
||
Rebased to pick up Kris's fix for bug 1258858 (the reviewboard interdiff is bogus...) (In reply to Dave Townsend [:mossop] from comment #3) > I'm ok with this as-is, but it might be nice to rather than only work for > this case to instead be able to merge in any other properties we like, say > even if the original has applications.chrome... defined we could still add > applciations.gecko... Yeah, I started doing something more elaborate but then backed off in the name of simplicity. For now (and probably the forseeable future) the application property is still mozilla-specific. I think if the webextensions standardization picks up steam, this will be an obvious thing to get a standardized definition for and we can pick it back up then.
Keywords: checkin-needed,
dev-doc-needed
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/983702f6874c
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•