Closed Bug 1255688 Opened 4 years ago Closed 3 years ago

The TypeFromSize() function does not support odd width/height.

Categories

(Core :: Canvas: 2D, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: kaku, Assigned: kaku)

References

Details

Attachments

(1 file)

For example:
A YV16 image with y-width 21 should have cbcr-width to be 11.


So, the code in this line(https://dxr.mozilla.org/mozilla-central/source/gfx/ycbcr/yuv_convert.cpp#42) should be:

  else if ((ywidth + 1) / 2 == cbcrwidth && yheight == cbcrheight) {
Assignee: nobody → tkuo
Blocks: 1141979
Attachment #8729342 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8729342 [details]
MozReview Request: Bug 1255688 - Fix TypeFromSize for YV16 case; r=jrmuizel

https://reviewboard.mozilla.org/r/39387/#review52694
Comment on attachment 8729342 [details]
MozReview Request: Bug 1255688 - Fix TypeFromSize for YV16 case; r=jrmuizel

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/39387/diff/1-2/
Attachment #8729342 - Attachment description: MozReview Request: Bug 1255688 - Fix TypeFromSize for YV16 case; r?jrmuizel → MozReview Request: Bug 1255688 - Fix TypeFromSize for YV16 case; r=jrmuizel
Try looks good:https://treeherder.mozilla.org/#/jobs?repo=try&revision=8c395eef28f5

Thanks for the review!
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f5804d79ba15
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.