The TypeFromSize() function does not support odd width/height.

RESOLVED FIXED in Firefox 49

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: kaku, Assigned: kaku)

Tracking

unspecified
mozilla49
Points:
---

Firefox Tracking Flags

(firefox49 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
For example:
A YV16 image with y-width 21 should have cbcr-width to be 11.


So, the code in this line(https://dxr.mozilla.org/mozilla-central/source/gfx/ycbcr/yuv_convert.cpp#42) should be:

  else if ((ywidth + 1) / 2 == cbcrwidth && yheight == cbcrheight) {
(Assignee)

Comment 1

3 years ago
Created attachment 8729342 [details]
MozReview Request: Bug 1255688 - Fix TypeFromSize for YV16 case; r=jrmuizel

Review commit: https://reviewboard.mozilla.org/r/39387/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39387/
Attachment #8729342 - Flags: review?(jmuizelaar)
(Assignee)

Updated

3 years ago
Assignee: nobody → tkuo
(Assignee)

Updated

3 years ago
Blocks: 1141979
Attachment #8729342 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8729342 [details]
MozReview Request: Bug 1255688 - Fix TypeFromSize for YV16 case; r=jrmuizel

https://reviewboard.mozilla.org/r/39387/#review52694
(Assignee)

Comment 3

3 years ago
Comment on attachment 8729342 [details]
MozReview Request: Bug 1255688 - Fix TypeFromSize for YV16 case; r=jrmuizel

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/39387/diff/1-2/
Attachment #8729342 - Attachment description: MozReview Request: Bug 1255688 - Fix TypeFromSize for YV16 case; r?jrmuizel → MozReview Request: Bug 1255688 - Fix TypeFromSize for YV16 case; r=jrmuizel
(Assignee)

Comment 4

3 years ago
Try looks good:https://treeherder.mozilla.org/#/jobs?repo=try&revision=8c395eef28f5

Thanks for the review!
(Assignee)

Updated

3 years ago
Keywords: checkin-needed

Comment 6

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f5804d79ba15
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.