1255688 - The TypeFromSize() function does not support odd width/height.

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Tzuhao Kuo [:kaku]]

For example:
A YV16 image with y-width 21 should have cbcr-width to be 11.


So, the code in this line(https://dxr.mozilla.org/mozilla-central/source/gfx/ycbcr/yuv_convert.cpp#42) should be:

  else if ((ywidth + 1) / 2 == cbcrwidth && yheight == cbcrheight) {

Comment 1

[Tzuhao Kuo [:kaku]]

Attachment: MozReview Request: Bug 1255688 - Fix TypeFromSize for YV16 case; r=jrmuizel

Review commit: https://reviewboard.mozilla.org/r/39387/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39387/

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8729342 [details]
MozReview Request: Bug 1255688 - Fix TypeFromSize for YV16 case; r=jrmuizel

https://reviewboard.mozilla.org/r/39387/#review52694

Comment 3

[Tzuhao Kuo [:kaku]]

Comment on attachment 8729342 [details]
MozReview Request: Bug 1255688 - Fix TypeFromSize for YV16 case; r=jrmuizel

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/39387/diff/1-2/

Comment 4

[Tzuhao Kuo [:kaku]]

Try looks good:https://treeherder.mozilla.org/#/jobs?repo=try&revision=8c395eef28f5

Thanks for the review!

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f5804d79ba15

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f5804d79ba15