Closed
Bug 1255710
Opened 8 years ago
Closed 8 years ago
Enable tests for 'transform-style: preserve-3d' in test_animation_property_state.html
Categories
(Core :: DOM: Animation, defect)
Core
DOM: Animation
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: hiro, Unassigned)
References
Details
Attachments
(4 files, 3 obsolete files)
Attaching patch includes an mochitest. If you run the test once, the test will succeed. But if you run the test repeatedly, say with --run-until-failure option, it will fail. The test just does: // create animation var anim = div.animate({ opacity: [0, 1], transform: ['translate(0px)', 'translate(100px)'] }, 100000); // wait a frame // check that the animation is running on compositor assert_true(isRunningOnCompositor); // add the obstacle style div.style = 'transform-style: preserve-3d'; // wait a frame // check that the animation is not running on compositor assert_false(isRunningOnCompositor); // remove the obstacle style div.style = ''; // wait a frame // check that the animation is running on compositor assert_true(isRunningOnCompositor); The first run of this test surely succeeds, but the third assertion on the second run certainly fails on my local linux box.
Reporter | ||
Comment 1•8 years ago
|
||
Reporter | ||
Comment 2•8 years ago
|
||
(In reply to Hiroyuki Ikezoe (:hiro) from comment #0) > // remove the obstacle style > div.style = ''; > // wait a frame > // check that the animation is running on compositor > assert_true(isRunningOnCompositor); > > > The first run of this test surely succeeds, but the third assertion on the > second run certainly fails on my local linux box. The warning message at the failure point is: Async animation of 'transform-style: preserve-3d' transforms is not supported
Reporter | ||
Comment 3•8 years ago
|
||
I did misunderstand --run-until-failure. (In reply to Hiroyuki Ikezoe (:hiro) from comment #0) > The first run of this test surely succeeds, but the third assertion on the > second run certainly fails on my local linux box. Actually this is not the second run. The failure case is that the test run in iframe.
Reporter | ||
Comment 4•8 years ago
|
||
This issue is highly related to other preserve-3d issues.
Summary: Async animations don't come back to compositor reliably even if an obstacle style is removed → Removing 'transform-style: preserve-3d' should push transform animations back to compositor
Reporter | ||
Comment 5•8 years ago
|
||
Just confirmed that the patches in bug 1250718 solves this bug.
Reporter | ||
Comment 6•8 years ago
|
||
Bug 12507180 has been fixed, now it's the time to enable those tests in test_animation_property_state.html.
Summary: Removing 'transform-style: preserve-3d' should push transform animations back to compositor → Enable tests for 'transform-style: preserve-3d' in test_animation_property_state.html
Comment 7•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/42711/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/42711/
Attachment #8735329 -
Flags: review?(bbirtles)
Attachment #8735330 -
Flags: review?(bbirtles)
Attachment #8735331 -
Flags: review?(bbirtles)
Comment 8•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/42713/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/42713/
Comment 9•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/42715/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/42715/
Reporter | ||
Comment 10•8 years ago
|
||
Oh my gosh! The account is a dummy account which I created for that event!
Reporter | ||
Updated•8 years ago
|
Attachment #8735329 -
Flags: review?(bbirtles)
Reporter | ||
Updated•8 years ago
|
Attachment #8735330 -
Flags: review?(bbirtles)
Reporter | ||
Updated•8 years ago
|
Attachment #8735331 -
Flags: review?(bbirtles)
Updated•8 years ago
|
Attachment #8735331 -
Attachment is obsolete: true
Updated•8 years ago
|
Attachment #8735329 -
Attachment is obsolete: true
Updated•8 years ago
|
Attachment #8735330 -
Attachment is obsolete: true
Reporter | ||
Comment 11•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/42733/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/42733/
Attachment #8735332 -
Flags: review?(bbirtles)
Attachment #8735333 -
Flags: review?(bbirtles)
Attachment #8735334 -
Flags: review?(bbirtles)
Reporter | ||
Comment 12•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/42735/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/42735/
Reporter | ||
Comment 13•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/42737/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/42737/
Updated•8 years ago
|
Attachment #8735332 -
Flags: review?(bbirtles) → review+
Comment 14•8 years ago
|
||
Comment on attachment 8735332 [details] MozReview Request: Bug 1255710 - Part 0: Rename test_animation_property_state.html to test_animation_performance_warning.html. r?birtles https://reviewboard.mozilla.org/r/42733/#review39407 The commit message here needs to be updated from "est_animation_property_state.html" to "test_animation_property_state.html"
Comment 15•8 years ago
|
||
Comment on attachment 8735333 [details] MozReview Request: Bug 1255710 - Part 1: Remove all unnecessary t.step_func. r?birtles https://reviewboard.mozilla.org/r/42735/#review39409
Attachment #8735333 -
Flags: review?(bbirtles) → review+
Updated•8 years ago
|
Attachment #8735334 -
Flags: review?(bbirtles) → review+
Comment 16•8 years ago
|
||
Comment on attachment 8735334 [details] MozReview Request: Bug 1255710 - Part 2: Enable tests for 'transform-style: preserve-3d'. r?birtles https://reviewboard.mozilla.org/r/42737/#review39411 Before landing this, we should make sure we have a try run with a lot of retriggers to be sure this doesn't fail intermittently.
Reporter | ||
Comment 17•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=61eaeed66571
Reporter | ||
Comment 18•8 years ago
|
||
Comment on attachment 8735332 [details] MozReview Request: Bug 1255710 - Part 0: Rename test_animation_property_state.html to test_animation_performance_warning.html. r?birtles Review request updated; see interdiff: https://reviewboard.mozilla.org/r/42733/diff/1-2/
Attachment #8735332 -
Attachment description: MozReview Request: Bug 1255710 - Part 0: Rename est_animation_property_state.html to test_animation_performance_warning.html. r?birtles → MozReview Request: Bug 1255710 - Part 0: Rename test_animation_property_state.html to test_animation_performance_warning.html. r?birtles
Reporter | ||
Comment 19•8 years ago
|
||
Comment on attachment 8735333 [details] MozReview Request: Bug 1255710 - Part 1: Remove all unnecessary t.step_func. r?birtles Review request updated; see interdiff: https://reviewboard.mozilla.org/r/42735/diff/1-2/
Reporter | ||
Comment 20•8 years ago
|
||
Comment on attachment 8735334 [details] MozReview Request: Bug 1255710 - Part 2: Enable tests for 'transform-style: preserve-3d'. r?birtles Review request updated; see interdiff: https://reviewboard.mozilla.org/r/42737/diff/1-2/
Comment 21•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/3d848bfe065d https://hg.mozilla.org/integration/mozilla-inbound/rev/98655db9da52 https://hg.mozilla.org/integration/mozilla-inbound/rev/80660b035524
Comment 22•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3d848bfe065d https://hg.mozilla.org/mozilla-central/rev/98655db9da52 https://hg.mozilla.org/mozilla-central/rev/80660b035524
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•