Open
Bug 1255758
Opened 8 years ago
Updated 2 years ago
Merge SID-handling code in ssl_BeginClientHandshake() and ssl3_SendClientHello()
Categories
(NSS :: Libraries, defect, P3)
NSS
Libraries
Tracking
(firefox48 affected)
NEW
| Tracking | Status | |
|---|---|---|
| firefox48 | --- | affected |
People
(Reporter: ttaubert, Unassigned)
References
Details
(Keywords: good-first-bug)
From ssl3_SendClientHello():
> /* We ignore ss->sec.ci.sid here, and use ssl_Lookup because Lookup
> * handles expired entries and other details.
> * XXX If we've been called from ssl_BeginClientHandshake, then
> * this lookup is duplicative and wasteful.
> */
The SID-handling code in ssl_BeginClientHandshake() can potentially be removed as ssl3_SendClientHello() is doing a lot of the work again. Some (all?) of the code in ssl_BeginClientHandshake() might also just be there to support v2 detection in the past, although it does some stuff the v3 code doesn't, e.g. duplicate localCert.
|
Reporter | |
Updated•7 years ago
|
Keywords: good-first-bug
Priority: -- → P3
|
||
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•