1255758 - Merge SID-handling code in ssl_BeginClientHandshake() and ssl3_SendClientHello()

Status: NEW

(NSS :: Libraries, defect, P3)

Description

[Tim Taubert [:ttaubert] (inactive)]

From ssl3_SendClientHello():

> /* We ignore ss->sec.ci.sid here, and use ssl_Lookup because Lookup
>  * handles expired entries and other details.
>  * XXX If we've been called from ssl_BeginClientHandshake, then
>  * this lookup is duplicative and wasteful.
>  */

The SID-handling code in ssl_BeginClientHandshake() can potentially be removed as ssl3_SendClientHello() is doing a lot of the work again. Some (all?) of the code in ssl_BeginClientHandshake() might also just be there to support v2 detection in the past, although it does some stuff the v3 code doesn't, e.g. duplicate localCert.