Closed Bug 1255766 Opened 6 years ago Closed 6 years ago

Tracelogger: mark resizing of memory also

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: h4writer, Assigned: h4writer)

Details

Attachments

(1 file)

We currently mark the time being internal "Tracelogger" time, when there is not enough memory left and we have to flush the data. But we don't do this, whenever we enlarge the storage where we save it. This can also be a large time and look suspicious on graphs... It is better to make it clear this is time the Tracelogger used internally.
Attached patch PatchSplinter Review
Account the time we enlarge the inner storage to time spend in TL, instead of time in the tracelogger item... Making the graphs more correct to interpret.
Assignee: nobody → hv1989
Attachment #8729492 - Flags: review?(bbouvier)
Comment on attachment 8729492 [details] [diff] [review]
Patch

Review of attachment 8729492 [details] [diff] [review]:
-----------------------------------------------------------------

Yep, makes sense.
Attachment #8729492 - Flags: review?(bbouvier) → review+
https://hg.mozilla.org/mozilla-central/rev/e1f5afcd210c
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.