Closed
Bug 1255766
Opened 9 years ago
Closed 9 years ago
Tracelogger: mark resizing of memory also
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla48
| Tracking | Status | |
|---|---|---|
| firefox48 | --- | fixed |
People
(Reporter: h4writer, Assigned: h4writer)
Details
Attachments
(1 file)
|
2.98 KB,
patch
|
bbouvier
:
review+
|
Details | Diff | Splinter Review |
We currently mark the time being internal "Tracelogger" time, when there is not enough memory left and we have to flush the data. But we don't do this, whenever we enlarge the storage where we save it. This can also be a large time and look suspicious on graphs... It is better to make it clear this is time the Tracelogger used internally.
|
Assignee | |
Comment 1•9 years ago
|
||
Account the time we enlarge the inner storage to time spend in TL, instead of time in the tracelogger item... Making the graphs more correct to interpret.
Assignee: nobody → hv1989
Attachment #8729492 -
Flags: review?(bbouvier)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8729492 [details] [diff] [review]
Patch
Review of attachment 8729492 [details] [diff] [review]:
-----------------------------------------------------------------
Yep, makes sense.
Attachment #8729492 -
Flags: review?(bbouvier) → review+
|
||
Comment 4•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•