unable to highlight revisions in the UI anymore, nor ignore highlighted alerts

RESOLVED FIXED

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jmaher, Assigned: wlach)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
we now have 2 ways to highlight revisions:
1) user input in the UI
2) data from alerts

These are both awesome methods, but in adding highlighted alerts, I think we have a regression.

Take for example:
https://treeherder.mozilla.org/perf.html#/graphs?series=%5Bmozilla-inbound,3ca421edff9b1e444f7ae93c7b2a09a96a8e8ec5,1%5D&zoom=1457379960421.4285,1457391298278.2493,476.57799090670386,536.2123243183484&selected=%5Bmozilla-inbound,3ca421edff9b1e444f7ae93c7b2a09a96a8e8ec5,27970,23355435%5D

try to highlight revision: b5621f52feab

you will not see it highlight, nor will you see any other revision you try to highlight.

Now click on the checkbox to 'unhide alert highlighting', nothing changes.

I assume there is a small but simple fix to make this all work together again.  Not sure if we can realistically make some unittests for this.
Created attachment 8738822 [details] [review]
[treeherder] wlach:1255797 > mozilla:master
Attachment #8738822 - Flags: review?(jmaher)
Assignee: nobody → wlachance
It would be nice to be able to unit test the UI, but there aren't any reasonable options for that at the moment. Maybe someday...
(Reporter)

Updated

3 years ago
Attachment #8738822 - Flags: review?(jmaher) → review+
Keywords: autoland
Keywords: autoland
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.