Closed Bug 1255819 Opened 4 years ago Closed 4 years ago

SelectionHandler needs to use correct type=number <input> field to support copy/paste

Categories

(Firefox for Android :: Text Selection, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 48
Tracking Status
firefox48 --- fixed

People

(Reporter: capella, Assigned: capella)

References

Details

User Story

Basically what the title says. See bug 1224216 comment 17.

Attachments

(1 file)

No description provided.
User Story: (updated)
Attached patch bug1255819.diffSplinter Review
With prereq #1 (bug 1224216), and prereq #2 (bug 1254096) under review, I can point out the minor changes to SelectionHandler that it will take to compelete this train of thought, and allow handling of text in <input> type=number fields.

Fairly simple, and testable in nightly still due to our current dual-support of the old and new code.

set: layout.accessiblecaret.enabled = false
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
Attachment #8730074 - Flags: review?(margaret.leibovic)
convenient test page, both type=text and type=number inputs
https://www.dropbox.com/s/lhr0sb77ueasijg/simpleVariousInputs.html?dl=0
Comment on attachment 8730074 [details] [diff] [review]
bug1255819.diff

Review of attachment 8730074 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry I've been so slow to get around to this review. It's been a while since I've looked at this code closely, so I'm not as familiar with it. This seems reasonable to me, but you should see if there's someone else who can lend an additional review if there's anything you're worried about here.
Attachment #8730074 - Flags: review?(margaret.leibovic) → review+
I'm pretty comfy with this, I poked around a lot during research and testing for the yucks. The small bugfixs it drove out in browser.js and core|nsIDocument::CaretPositionFromPoint| paid for it.

It's:
   a pretty tiny use-case
   pretty fail-safe in it's specific module
   easy to correct quickly if I've erred somehow
   able to be frozen in m-c where it's pref-ed off
   able to bake in aurora if you decide to promote
https://hg.mozilla.org/mozilla-central/rev/b999fac0569d
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
You need to log in before you can comment on or make changes to this bug.