1255891 - [e10s] imagebitmap canvas tests seem to leak an arbitrary amount of textures in Windows with e10s

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect, P2)

Description

[Andrew McCreight [:mccr8]]

As seen in bug 1252677, canvas mochitests leak textures on Windows. By logging the ctor and dtor of TextureChild, I found that these textures are allocated during two specific tests, test_imagebitmap_cropping.html and test_imagebitmap.html.

If you run these tests multiple times, you leak even more: https://treeherder.mozilla.org/logviewer.html#?job_id=17966187&repo=try

These leaks don't show up as being very large in the XPCOM leak detector, but I assume that because SharedMemory is being leaked that the actual size of the leak could be much larger.

Comment 1

[Andrew McCreight [:mccr8]]

(By "arbitrary", I just mean, the more times you run the test, the more textures you seem to leak.)

Comment 2

[Andrew McCreight [:mccr8]]

test_capture.html also seems to leak textures sometimes.

Comment 3

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

ni?kaku as he wrote the code tested here (and the tests).

Comment 4

[Bas Schouten (:bas.schouten)]

Should have been fixed.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

I re-enabled dom/canvas on Windows, mccr8 removed all the leak annotations, and Ash is green. I think we can declare victory here :)