Closed Bug 1255891 Opened 8 years ago Closed 8 years ago

[e10s] imagebitmap canvas tests seem to leak an arbitrary amount of textures in Windows with e10s

Categories

(Core :: Graphics: Canvas2D, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
e10s + ---
firefox47 --- affected
firefox48 --- fixed

People

(Reporter: mccr8, Assigned: bas.schouten)

References

Details

(Keywords: memory-leak, Whiteboard: [gfx-noted][e10s-orangeblockers])

As seen in bug 1252677, canvas mochitests leak textures on Windows. By logging the ctor and dtor of TextureChild, I found that these textures are allocated during two specific tests, test_imagebitmap_cropping.html and test_imagebitmap.html.

If you run these tests multiple times, you leak even more: https://treeherder.mozilla.org/logviewer.html#?job_id=17966187&repo=try

These leaks don't show up as being very large in the XPCOM leak detector, but I assume that because SharedMemory is being leaked that the actual size of the leak could be much larger.
(By "arbitrary", I just mean, the more times you run the test, the more textures you seem to leak.)
test_capture.html also seems to leak textures sometimes.
ni?kaku as he wrote the code tested here (and the tests).
Flags: needinfo?(tkuo)
Whiteboard: [MemShrink] → [MemShrink] [gfx-noted]
See Also: → 1256946
Whiteboard: [MemShrink] [gfx-noted] → [MemShrink][gfx-noted][e10s-orangeblockers]
Priority: -- → P2
Whiteboard: [MemShrink][gfx-noted][e10s-orangeblockers] → [gfx-noted][e10s-orangeblockers]
Should have been fixed.
Flags: needinfo?(tkuo)
I re-enabled dom/canvas on Windows, mccr8 removed all the leak annotations, and Ash is green. I think we can declare victory here :)
Assignee: nobody → bas
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.