Closed Bug 1255906 Opened 10 years ago Closed 9 years ago

Send Alert Text should accept input as array of characters

Categories

(Remote Protocol :: Marionette, defect)

Product:
Remote Protocol
Component:
Marionette
Version:
45 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: titus.fortner, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: pi-marionette-server)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/48.0.2564.116 Safari/537.36 Steps to reproduce: Sent text to an alert as both string & array of strings https://gist.github.com/titusfortner/c1d3ade1ce28e6941c85#file-text_to_alert Actual results: Errors Expected results: Text sent to an alert
According to the WebDriver spec only {text: ["f", "o", "o"]} should be allowed: http://w3c.github.io/webdriver/webdriver-spec.html#send-alert-text You can see the discussion in https://github.com/w3c/webdriver/pull/255 for some further context on this.
Status: UNCONFIRMED → RESOLVED
Closed: 10 years ago
Resolution: --- → INVALID
Yes, I did that here: https://gist.github.com/titusfortner/c1d3ade1ce28e6941c85#file-text_to_alert-L2 It gave the error: "invalid argument","message":"'text' not a string""
Status: RESOLVED → UNCONFIRMED
Resolution: INVALID → ---
You're right, Marionette currently accepts strings only. It should accept a sequence of character instead. Some backwards compatibility work will be required here.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: send text to alert → Send Alert Text should accept input as array of characters
This is working now
Marking as WFM based on reporters feedback. Thanks.
Status: NEW → RESOLVED
Closed: 10 years ago → 9 years ago
Resolution: --- → WORKSFORME
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.