Send Alert Text should accept input as array of characters

RESOLVED WORKSFORME

Status

defect
RESOLVED WORKSFORME
3 years ago
2 years ago

People

(Reporter: titus.fortner, Unassigned)

Tracking

(Blocks 1 bug, {pi-marionette-server})

45 Branch
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Reporter

Description

3 years ago
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/48.0.2564.116 Safari/537.36

Steps to reproduce:

Sent text to an alert as both string & array of strings
https://gist.github.com/titusfortner/c1d3ade1ce28e6941c85#file-text_to_alert


Actual results:

Errors


Expected results:

Text sent to an alert
According to the WebDriver spec only {text: ["f", "o", "o"]} should be allowed:

  http://w3c.github.io/webdriver/webdriver-spec.html#send-alert-text

You can see the discussion in https://github.com/w3c/webdriver/pull/255 for some further context on this.
Status: UNCONFIRMED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → INVALID
Reporter

Comment 2

3 years ago
Yes, I did that here:
https://gist.github.com/titusfortner/c1d3ade1ce28e6941c85#file-text_to_alert-L2

It gave the error:
"invalid argument","message":"'text' not a string""
Status: RESOLVED → UNCONFIRMED
Resolution: INVALID → ---
You're right, Marionette currently accepts strings only.  It should accept a sequence of character instead.  Some backwards compatibility work will be required here.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: send text to alert → Send Alert Text should accept input as array of characters
Reporter

Comment 4

2 years ago
This is working now
Marking as WFM based on reporters feedback. Thanks.
Status: NEW → RESOLVED
Last Resolved: 3 years ago2 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.