1255931 - Use @command for declaring commands

Status: RESOLVED FIXED

(Developer Services :: Mercurial: mozext, defect)

Description

[Gregory Szorc [:gps]]

Mercurial 3.8 breaks some legacy APIs around command declaration. I discovered this the hard way as part of running upstream tip locally. I have some patches to fix things.

Comment 1

[Gregory Szorc [:gps]]

Attachment: MozReview Request: mozext: don't use commands.norepo (bug 1255931); r?dminor

commands.norepo has been removed in Mercurial 3.8. The argument to
@command should be used instead.

Review commit: https://reviewboard.mozilla.org/r/39575/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39575/

Comment 2

[Gregory Szorc [:gps]]

Attachment: MozReview Request: bzexport: use @command for declaring commands (bug 1255931); r?dminor

Assigning a raw dict to cmdtable no longer works in Mercurial 3.8
because @command assigns attributes to the function that various parts
of Mercurial look for. @command has been around for ages. Use it.

Review commit: https://reviewboard.mozilla.org/r/39577/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39577/

Comment 3

[Gregory Szorc [:gps]]

Attachment: MozReview Request: mqext: use @command for declaring commands (bug 1255931); r?dminor

Populating the cmdtable dict directly is no longer supported in
Mercurial 3.8.

Review commit: https://reviewboard.mozilla.org/r/39579/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39579/

Comment 4

[Gregory Szorc [:gps]]

Attachment: MozReview Request: qbackout: use @command for declaring commands (bug 1255931); r?dminor

Support for directly populating cmdtable has been dropped in Mercurial
3.8.

Review commit: https://reviewboard.mozilla.org/r/39581/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39581/

Comment 5

[Dan Minor [:dminor]]

Comment on attachment 8729744 [details]
MozReview Request: mozext: don't use commands.norepo (bug 1255931); r?dminor

https://reviewboard.mozilla.org/r/39575/#review36317

Comment 6

[Dan Minor [:dminor]]

Comment on attachment 8729745 [details]
MozReview Request: bzexport: use @command for declaring commands (bug 1255931); r?dminor

https://reviewboard.mozilla.org/r/39577/#review36321

Comment 7

[Dan Minor [:dminor]]

Comment on attachment 8729746 [details]
MozReview Request: mqext: use @command for declaring commands (bug 1255931); r?dminor

https://reviewboard.mozilla.org/r/39579/#review36323

Comment 8

[Dan Minor [:dminor]]

Comment on attachment 8729747 [details]
MozReview Request: qbackout: use @command for declaring commands (bug 1255931); r?dminor

https://reviewboard.mozilla.org/r/39581/#review36325

Comment 9

[Gregory Szorc [:gps]]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/f838c187e321fc6ed5590147946380e5f558f408
mozext: don't use commands.norepo (bug 1255931); r=dminor

https://hg.mozilla.org/hgcustom/version-control-tools/rev/9263406bc3ca2d021461f675d0b2be3b6b78d8b2
bzexport: use @command for declaring commands (bug 1255931); r=dminor

https://hg.mozilla.org/hgcustom/version-control-tools/rev/16f671cc3ad6c2385eb0eeb3d9d38246d841a23f
mqext: use @command for declaring commands (bug 1255931); r=dminor

https://hg.mozilla.org/hgcustom/version-control-tools/rev/9fa41247b7e69be9fbd81c953df93ab3614cd0b1
qbackout: use @command for declaring commands (bug 1255931); r=dminor