1255987 - [DevTools][Memory] Incorrect description in tooltip of frame-link-filename

Status: NEW

(DevTools :: Memory, defect, P3)

Description

[magicp]

Attachment: frame-link-filename-tooltip.png

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:48.0) Gecko/20100101 Firefox/48.0
Build ID: 20160311030233

Steps to reproduce:

1. Start Nightly
2. Go to "about:home"
3. Open DevTools > Memory
4. Check-on "Record allocation stacks"
5. Reload current page
6. Switch group by to "Call Stack"
7. Take snapshot
8. Show tooltip of frame-link-filename (e.g. transport.js)


Actual results:

"View source in Debugger" is not in Debugger


Expected results:

Same with Browser Console.

Comment 1

[magicp]

> Expected results:
> 
> Same with Browser Console.
Browser Console was changed tooltip too...

ER: Change description to "in Debugger" or "in Browser" correctly.

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

It first attempts to open the source in the debugger, and if the source is not listed there, then it opens it in a new view-source:// tab.

I think we could just change this string to leave out "in <where>" completely.

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

Agreed; we could smartly change this for every viewing of source, but AFAIK we can't easily truly tell what type of file it is, so just leaving it as "view ____" is sufficient and accurate