Closed
Bug 125601
Opened 23 years ago
Closed 23 years ago
ABS()-->PR_ABS() && PR_ABS()-cleanup
Categories
(SeaMonkey :: General, defect, P3)
SeaMonkey
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla0.9.9
People
(Reporter: roland.mainz, Assigned: roland.mainz)
Details
Attachments
(1 file)
|
6.70 KB,
patch
|
timeless
:
review+
sfraser_bugs
:
superreview+
|
Details | Diff | Splinter Review |
bug 117479 ("RFE: Implement a PR_ABS() macro") introduced the PR_ABS() macro to
NSPR headers.
Unfortunately many people use things like:
-- snip --
#undef PR_ABS
#define PR_ABS (x>0)?x:-x
-- snip --
which is completly wrong (missing brackets about the |x|-usage in the macro and
the PR_* CPP namespace gets misused).
I'll file a patch to kill the crap and do some other ABS()-macro-related
cleanup...
|
Assignee | |
Updated•23 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P3
Target Milestone: --- → mozilla0.9.9
|
|
Assignee | |
Comment 2•23 years ago
|
||
Attachment #69568 -
Flags: review+
|
||
Comment 3•23 years ago
|
||
Comment on attachment 69568 [details] [diff] [review]
Patch
sr=sfraser
Attachment #69568 -
Flags: superreview+
|
|
Assignee | |
Comment 4•23 years ago
|
||
Patch checked in, marking bug as FIXED.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
|
||
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•