bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

ABS()-->PR_ABS() && PR_ABS()-cleanup

RESOLVED FIXED in mozilla0.9.9

Status

SeaMonkey
General
P3
normal
RESOLVED FIXED
17 years ago
14 years ago

People

(Reporter: Roland Mainz, Assigned: Roland Mainz)

Tracking

Trunk
mozilla0.9.9

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

17 years ago
bug 117479 ("RFE: Implement a PR_ABS() macro") introduced the PR_ABS() macro to
NSPR headers.

Unfortunately many people use things like:
-- snip --
#undef PR_ABS
#define PR_ABS (x>0)?x:-x
-- snip --
which is completly wrong (missing brackets about the |x|-usage in the macro and
the PR_* CPP namespace gets misused).

I'll file a patch to kill the crap and do some other ABS()-macro-related
cleanup...
(Assignee)

Comment 1

17 years ago
Taking...
Assignee: asa → Roland.Mainz
(Assignee)

Updated

17 years ago
Status: NEW → ASSIGNED
Priority: -- → P3
Target Milestone: --- → mozilla0.9.9
(Assignee)

Comment 2

17 years ago
Created attachment 69568 [details] [diff] [review]
Patch

Updated

17 years ago
Attachment #69568 - Flags: review+

Comment 3

17 years ago
Comment on attachment 69568 [details] [diff] [review]
Patch

sr=sfraser
Attachment #69568 - Flags: superreview+
(Assignee)

Comment 4

17 years ago
Patch checked in, marking bug as FIXED.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.