Intermittent leakcheck | default process: 5200 bytes leaked (CondVar, DOMEventTargetHelper, Mutex, ReentrantMonitor, TCPSocket, ...)

RESOLVED FIXED in Firefox 47

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: RyanVM, Assigned: mcmanus)

Tracking

({intermittent-failure, memory-leak})

Trunk
mozilla48
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox47 fixed, firefox48 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Reporter

Description

3 years ago
Unsurprisingly, this occured after running in dom/network/tests.

https://treeherder.mozilla.org/logviewer.html#?job_id=23629202&repo=mozilla-inbound

10:51:48     INFO -  nsTraceRefcnt::DumpStatistics: 1359 entries
10:51:48     INFO -  TEST-INFO | leakcheck | default process: leaked 3 CondVar
10:51:48     INFO -  TEST-INFO | leakcheck | default process: leaked 2 DOMEventTargetHelper
10:51:48     INFO -  TEST-INFO | leakcheck | default process: leaked 12 Mutex
10:51:48     INFO -  TEST-INFO | leakcheck | default process: leaked 2 ReentrantMonitor
10:51:48     INFO -  TEST-INFO | leakcheck | default process: leaked 2 TCPSocket
10:51:48     INFO -  TEST-INFO | leakcheck | default process: leaked 2 nsAsyncStreamCopier
10:51:48     INFO -  TEST-INFO | leakcheck | default process: leaked 2 nsDNSAsyncRequest
10:51:48     INFO -  TEST-INFO | leakcheck | default process: leaked 1 nsHostResolver
10:51:48     INFO -  TEST-INFO | leakcheck | default process: leaked 2 nsMultiplexInputStream
10:51:48     INFO -  TEST-INFO | leakcheck | default process: leaked 2 nsPipe
10:51:48     INFO -  TEST-INFO | leakcheck | default process: leaked 2 nsPipeInputStream
10:51:48     INFO -  TEST-INFO | leakcheck | default process: leaked 2 nsScriptableInputStream
10:51:48     INFO -  TEST-INFO | leakcheck | default process: leaked 2 nsSocketTransport
10:51:48     INFO -  TEST-INFO | leakcheck | default process: leaked 1 nsSocketTransportService
10:51:48     INFO -  TEST-INFO | leakcheck | default process: leaked 6 nsStringBuffer
10:51:48     INFO -  TEST-INFO | leakcheck | default process: leaked 8 nsTArray_base
10:51:48     INFO -  TEST-INFO | leakcheck | default process: leaked 1 nsThread
10:51:48     INFO -  TEST-INFO | leakcheck | default process: leaked 2 nsTransportEventSinkProxy
10:51:48  WARNING -  TEST-UNEXPECTED-FAIL | leakcheck | default process: 5200 bytes leaked (CondVar, DOMEventTargetHelper, Mutex, ReentrantMonitor, TCPSocket, ...)
Component: Networking → DOM: Device Interfaces
Comment hidden (Intermittent Failures Robot)
Assignee

Updated

3 years ago
Blocks: 698882
Assignee

Comment 2

3 years ago
Attachment #8733402 - Flags: review?(dd.mozilla)
Assignee

Updated

3 years ago
Assignee: nobody → mcmanus
Status: NEW → ASSIGNED
Assignee

Comment 3

3 years ago
I don't think this test really leaks, I just think it conspires to wait a long time for a bunch of windows to close and GC to catch up.. and on a slow test it can be too slow. These changes seem to help TCPSocket() cleanup happen a little earlier.
Attachment #8733402 - Flags: review?(dd.mozilla) → review+
Assignee

Comment 12

3 years ago
Bug 1256022 - test_tcpsocket_legacy.html slow GC r=dragana

break out a bigger hammer to break cycles even earlier

green at:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d1383e79227&selectedJob=18444467
Attachment #8733648 - Flags: review?(dd.mozilla)
Assignee

Updated

3 years ago
Attachment #8733402 - Attachment is obsolete: true
Attachment #8733648 - Flags: review?(dd.mozilla) → review+
Comment hidden (Intermittent Failures Robot)

Comment 25

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c110812ef14b
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Comment on attachment 8733648 [details] [diff] [review]
From 92966f6ad75f04310e1d211de5f2aac3d624f577 Mon Sep 17 00:00:00 2001

Approval Request Comment
[Feature/regressing bug #]: Needed for bug 698882
[User impact if declined]: Needed for a uplift of a bug that helps with a top crasher (shutdown hang). 
[Describe test coverage new/current, TreeHerder]: The change in bug 698882 has change timing which exposes a problem in a test. This bug improves the code that is used (is being tested) by the test. 
[Risks and why]: low
[String/UUID change made/needed]: none
Attachment #8733648 - Flags: approval-mozilla-aurora?
Comment on attachment 8733648 [details] [diff] [review]
From 92966f6ad75f04310e1d211de5f2aac3d624f577 Mon Sep 17 00:00:00 2001

fix for mlk, that was a side effect of the shutdown hang fixes uplifted to Aurora47, let's uplift this one too.
Attachment #8733648 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.