Closed
Bug 1256022
Opened 8 years ago
Closed 8 years ago
Intermittent leakcheck | default process: 5200 bytes leaked (CondVar, DOMEventTargetHelper, Mutex, ReentrantMonitor, TCPSocket, ...)
Categories
(Core :: DOM: Device Interfaces, defect)
Core
DOM: Device Interfaces
Tracking
()
RESOLVED
FIXED
mozilla48
People
(Reporter: RyanVM, Assigned: mcmanus)
References
Details
(Keywords: intermittent-failure, memory-leak)
Attachments
(1 file, 1 obsolete file)
8.95 KB,
patch
|
dragana
:
review+
ritu
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Unsurprisingly, this occured after running in dom/network/tests. https://treeherder.mozilla.org/logviewer.html#?job_id=23629202&repo=mozilla-inbound 10:51:48 INFO - nsTraceRefcnt::DumpStatistics: 1359 entries 10:51:48 INFO - TEST-INFO | leakcheck | default process: leaked 3 CondVar 10:51:48 INFO - TEST-INFO | leakcheck | default process: leaked 2 DOMEventTargetHelper 10:51:48 INFO - TEST-INFO | leakcheck | default process: leaked 12 Mutex 10:51:48 INFO - TEST-INFO | leakcheck | default process: leaked 2 ReentrantMonitor 10:51:48 INFO - TEST-INFO | leakcheck | default process: leaked 2 TCPSocket 10:51:48 INFO - TEST-INFO | leakcheck | default process: leaked 2 nsAsyncStreamCopier 10:51:48 INFO - TEST-INFO | leakcheck | default process: leaked 2 nsDNSAsyncRequest 10:51:48 INFO - TEST-INFO | leakcheck | default process: leaked 1 nsHostResolver 10:51:48 INFO - TEST-INFO | leakcheck | default process: leaked 2 nsMultiplexInputStream 10:51:48 INFO - TEST-INFO | leakcheck | default process: leaked 2 nsPipe 10:51:48 INFO - TEST-INFO | leakcheck | default process: leaked 2 nsPipeInputStream 10:51:48 INFO - TEST-INFO | leakcheck | default process: leaked 2 nsScriptableInputStream 10:51:48 INFO - TEST-INFO | leakcheck | default process: leaked 2 nsSocketTransport 10:51:48 INFO - TEST-INFO | leakcheck | default process: leaked 1 nsSocketTransportService 10:51:48 INFO - TEST-INFO | leakcheck | default process: leaked 6 nsStringBuffer 10:51:48 INFO - TEST-INFO | leakcheck | default process: leaked 8 nsTArray_base 10:51:48 INFO - TEST-INFO | leakcheck | default process: leaked 1 nsThread 10:51:48 INFO - TEST-INFO | leakcheck | default process: leaked 2 nsTransportEventSinkProxy 10:51:48 WARNING - TEST-UNEXPECTED-FAIL | leakcheck | default process: 5200 bytes leaked (CondVar, DOMEventTargetHelper, Mutex, ReentrantMonitor, TCPSocket, ...)
Updated•8 years ago
|
Component: Networking → DOM: Device Interfaces
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 2•8 years ago
|
||
Attachment #8733402 -
Flags: review?(dd.mozilla)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → mcmanus
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•8 years ago
|
||
I don't think this test really leaks, I just think it conspires to wait a long time for a bunch of windows to close and GC to catch up.. and on a slow test it can be too slow. These changes seem to help TCPSocket() cleanup happen a little earlier.
Assignee | ||
Comment 4•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fcd749419b3c
Updated•8 years ago
|
Attachment #8733402 -
Flags: review?(dd.mozilla) → review+
Assignee | ||
Comment 5•8 years ago
|
||
sigh.. not good enough https://treeherder.mozilla.org/#/jobs?repo=try&revision=5fca2372e1f5&selectedJob=18423278&filter-searchStr=OS%20X%2010.6%20debug%20Mochitest%20Mochitest%20M(2)
Assignee | ||
Comment 6•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=771f1c23e336
Assignee | ||
Comment 7•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=89cb8db86ddc
Assignee | ||
Comment 8•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e4b39119e0fc
Assignee | ||
Comment 9•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=996161cbbcd0
Assignee | ||
Comment 10•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7d61309accc4
Assignee | ||
Comment 11•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f95f1fa33d08
Assignee | ||
Comment 12•8 years ago
|
||
Bug 1256022 - test_tcpsocket_legacy.html slow GC r=dragana break out a bigger hammer to break cycles even earlier green at: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d1383e79227&selectedJob=18444467
Attachment #8733648 -
Flags: review?(dd.mozilla)
Assignee | ||
Updated•8 years ago
|
Attachment #8733402 -
Attachment is obsolete: true
Updated•8 years ago
|
Attachment #8733648 -
Flags: review?(dd.mozilla) → review+
Assignee | ||
Comment 13•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/f57f85dc94e4fad0f348d35c176a5b63b972bd65 Bug 1256022 - dom/network slow GC on mochitest fix r=dragana
Assignee | ||
Comment 14•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d6ccfd400a7f77151c888a975412b1532dc3df96 Bug 1256022 - backout f57f85dc94e4 r=backout
Assignee | ||
Comment 15•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9fd31871e051
Assignee | ||
Comment 16•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=29b28143f815
Assignee | ||
Comment 17•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=72e5ce88616a
Assignee | ||
Comment 18•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=82e52d543a1f
Assignee | ||
Comment 19•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f7d5c9761d80
Assignee | ||
Comment 20•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8e3c492f466b
Assignee | ||
Comment 21•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0b947446c53f
Assignee | ||
Comment 22•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=382003a47307
Assignee | ||
Comment 23•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c110812ef14b632e5ed5da9ca823d7492ffa38a4 Bug 1256022 - dom/network slow GC on mochitest fix r=dragana
Comment hidden (Intermittent Failures Robot) |
Comment 25•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c110812ef14b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Comment 26•8 years ago
|
||
Comment on attachment 8733648 [details] [diff] [review] From 92966f6ad75f04310e1d211de5f2aac3d624f577 Mon Sep 17 00:00:00 2001 Approval Request Comment [Feature/regressing bug #]: Needed for bug 698882 [User impact if declined]: Needed for a uplift of a bug that helps with a top crasher (shutdown hang). [Describe test coverage new/current, TreeHerder]: The change in bug 698882 has change timing which exposes a problem in a test. This bug improves the code that is used (is being tested) by the test. [Risks and why]: low [String/UUID change made/needed]: none
Attachment #8733648 -
Flags: approval-mozilla-aurora?
Comment on attachment 8733648 [details] [diff] [review] From 92966f6ad75f04310e1d211de5f2aac3d624f577 Mon Sep 17 00:00:00 2001 fix for mlk, that was a side effect of the shutdown hang fixes uplifted to Aurora47, let's uplift this one too.
Attachment #8733648 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
status-firefox47:
--- → affected
Comment 28•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/d10b04bf3016
You need to log in
before you can comment on or make changes to this bug.
Description
•