1256022 - Intermittent leakcheck | default process: 5200 bytes leaked (CondVar, DOMEventTargetHelper, Mutex, ReentrantMonitor, TCPSocket, ...)

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

Unsurprisingly, this occured after running in dom/network/tests.

https://treeherder.mozilla.org/logviewer.html#?job_id=23629202&repo=mozilla-inbound

10:51:48     INFO -  nsTraceRefcnt::DumpStatistics: 1359 entries
10:51:48     INFO -  TEST-INFO | leakcheck | default process: leaked 3 CondVar
10:51:48     INFO -  TEST-INFO | leakcheck | default process: leaked 2 DOMEventTargetHelper
10:51:48     INFO -  TEST-INFO | leakcheck | default process: leaked 12 Mutex
10:51:48     INFO -  TEST-INFO | leakcheck | default process: leaked 2 ReentrantMonitor
10:51:48     INFO -  TEST-INFO | leakcheck | default process: leaked 2 TCPSocket
10:51:48     INFO -  TEST-INFO | leakcheck | default process: leaked 2 nsAsyncStreamCopier
10:51:48     INFO -  TEST-INFO | leakcheck | default process: leaked 2 nsDNSAsyncRequest
10:51:48     INFO -  TEST-INFO | leakcheck | default process: leaked 1 nsHostResolver
10:51:48     INFO -  TEST-INFO | leakcheck | default process: leaked 2 nsMultiplexInputStream
10:51:48     INFO -  TEST-INFO | leakcheck | default process: leaked 2 nsPipe
10:51:48     INFO -  TEST-INFO | leakcheck | default process: leaked 2 nsPipeInputStream
10:51:48     INFO -  TEST-INFO | leakcheck | default process: leaked 2 nsScriptableInputStream
10:51:48     INFO -  TEST-INFO | leakcheck | default process: leaked 2 nsSocketTransport
10:51:48     INFO -  TEST-INFO | leakcheck | default process: leaked 1 nsSocketTransportService
10:51:48     INFO -  TEST-INFO | leakcheck | default process: leaked 6 nsStringBuffer
10:51:48     INFO -  TEST-INFO | leakcheck | default process: leaked 8 nsTArray_base
10:51:48     INFO -  TEST-INFO | leakcheck | default process: leaked 1 nsThread
10:51:48     INFO -  TEST-INFO | leakcheck | default process: leaked 2 nsTransportEventSinkProxy
10:51:48  WARNING -  TEST-UNEXPECTED-FAIL | leakcheck | default process: 5200 bytes leaked (CondVar, DOMEventTargetHelper, Mutex, ReentrantMonitor, TCPSocket, ...)

Comment 1

[Intermittent Failures Robot]

7 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 5
* fx-team: 2

Platform breakdown:
* osx-10-6: 6
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1256022&startday=2016-03-14&endday=2016-03-20&tree=all

Comment 2

[Patrick McManus [:mcmanus]]

Attachment: test_tcpsocket_legacy.html slow GC

Comment 3

[Patrick McManus [:mcmanus]]

I don't think this test really leaks, I just think it conspires to wait a long time for a bunch of windows to close and GC to catch up.. and on a slow test it can be too slow. These changes seem to help TCPSocket() cleanup happen a little earlier.

Comment 4

[Patrick McManus [:mcmanus]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fcd749419b3c

Comment 5

[Patrick McManus [:mcmanus]]

sigh.. not good enough

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5fca2372e1f5&selectedJob=18423278&filter-searchStr=OS%20X%2010.6%20debug%20Mochitest%20Mochitest%20M(2)

Comment 6

[Patrick McManus [:mcmanus]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=771f1c23e336

Comment 7

[Patrick McManus [:mcmanus]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=89cb8db86ddc

Comment 8

[Patrick McManus [:mcmanus]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e4b39119e0fc

Comment 9

[Patrick McManus [:mcmanus]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=996161cbbcd0

Comment 10

[Patrick McManus [:mcmanus]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7d61309accc4

Comment 11

[Patrick McManus [:mcmanus]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f95f1fa33d08

Comment 12

[Patrick McManus [:mcmanus]]

Attachment: From 92966f6ad75f04310e1d211de5f2aac3d624f577 Mon Sep 17 00:00:00 2001

Bug 1256022 - test_tcpsocket_legacy.html slow GC r=dragana

break out a bigger hammer to break cycles even earlier

green at:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d1383e79227&selectedJob=18444467

Comment 13

[Patrick McManus [:mcmanus]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f57f85dc94e4fad0f348d35c176a5b63b972bd65
Bug 1256022 - dom/network slow GC on mochitest fix r=dragana

Comment 14

[Patrick McManus [:mcmanus]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d6ccfd400a7f77151c888a975412b1532dc3df96
Bug 1256022 - backout f57f85dc94e4 r=backout

Comment 15

[Patrick McManus [:mcmanus]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9fd31871e051

Comment 16

[Patrick McManus [:mcmanus]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=29b28143f815

Comment 17

[Patrick McManus [:mcmanus]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=72e5ce88616a

Comment 18

[Patrick McManus [:mcmanus]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=82e52d543a1f

Comment 19

[Patrick McManus [:mcmanus]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f7d5c9761d80

Comment 20

[Patrick McManus [:mcmanus]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8e3c492f466b

Comment 21

[Patrick McManus [:mcmanus]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0b947446c53f

Comment 22

[Patrick McManus [:mcmanus]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=382003a47307

Comment 23

[Patrick McManus [:mcmanus]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c110812ef14b632e5ed5da9ca823d7492ffa38a4
Bug 1256022 - dom/network slow GC on mochitest fix r=dragana

Comment 24

[Intermittent Failures Robot]

6 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 4
* fx-team: 2

Platform breakdown:
* osx-10-6: 6

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1256022&startday=2016-03-21&endday=2016-03-27&tree=all

Comment 25

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c110812ef14b

Comment 26

[Dragana Damjanovic [:dragana]]

Comment on attachment 8733648 [details] [diff] [review]
From 92966f6ad75f04310e1d211de5f2aac3d624f577 Mon Sep 17 00:00:00 2001

Approval Request Comment
[Feature/regressing bug #]: Needed for bug 698882
[User impact if declined]: Needed for a uplift of a bug that helps with a top crasher (shutdown hang). 
[Describe test coverage new/current, TreeHerder]: The change in bug 698882 has change timing which exposes a problem in a test. This bug improves the code that is used (is being tested) by the test. 
[Risks and why]: low
[String/UUID change made/needed]: none

Comment 27

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8733648 [details] [diff] [review]
From 92966f6ad75f04310e1d211de5f2aac3d624f577 Mon Sep 17 00:00:00 2001

fix for mlk, that was a side effect of the shutdown hang fixes uplifted to Aurora47, let's uplift this one too.

Comment 28

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d10b04bf3016