Closed Bug 1256024 Opened 4 years ago Closed 4 years ago
C4838 conversion from 'uint32
_t' to 'int' requires a narrowing conversion
58 bytes, text/x-review-board-request
The following warnings are currently suppressed in VS2015 due to bug 1124033. Remove "-Wv:18" from old-configure.in to reproduce them. dom/plugins/ipc/PluginInstanceChild.cpp:3372 [C4838] conversion from 'uint32_t' to 'int' requires a narrowing conversion dom/plugins/ipc/PluginInstanceChild.cpp:3376 [C4838] conversion from 'LPARAM' to 'uintptr_t' requires a narrowing conversion dom/plugins/ipc/PluginInstanceParent.cpp:1373 [C4838] conversion from 'int32_t' to 'uint16_t' requires a narrowing conversion dom/plugins/test/testplugin/nptest_windows.cpp:809 [C4838] conversion from 'LPARAM' to 'uintptr_t' requires a narrowing conversion
This is blocking roll-out of VS2015. I'll likely provide a workaround patch that adds -Wd4838 to CXXFLAGS. But I encourage the underlying problem to be fixed.
As part of unblocking building with VS2015u1 in automation, I'm mass disabling compiler warnings that are turned into errors. This is not the preferred mechanism to fix compilation warnings. So hopefully this patch never lands because someone insists of fixing the underlying problem instead. But if it does land, hopefully the workaround is only temporary. Review commit: https://reviewboard.mozilla.org/r/39847/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/39847/
Attachment #8730410 - Flags: review?(aklotz)
Comment on attachment 8730410 [details] MozReview Request: Bug 1256024 - Disable C4838 to unblock compilation on VS2015; r?aklotz https://reviewboard.mozilla.org/r/39847/#review36443 Makes sense.
You need to log in before you can comment on or make changes to this bug.