Closed
Bug 1256024
Opened 6 years ago
Closed 6 years ago
C4838 conversion from 'uint32_t' to 'int' requires a narrowing conversion
Categories
(Core Graveyard :: Plug-ins, defect)
Core Graveyard
Plug-ins
Tracking
(firefox48 fixed)
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: gps, Unassigned)
References
Details
Attachments
(1 file)
The following warnings are currently suppressed in VS2015 due to bug 1124033. Remove "-Wv:18" from old-configure.in to reproduce them. dom/plugins/ipc/PluginInstanceChild.cpp:3372 [C4838] conversion from 'uint32_t' to 'int' requires a narrowing conversion dom/plugins/ipc/PluginInstanceChild.cpp:3376 [C4838] conversion from 'LPARAM' to 'uintptr_t' requires a narrowing conversion dom/plugins/ipc/PluginInstanceParent.cpp:1373 [C4838] conversion from 'int32_t' to 'uint16_t' requires a narrowing conversion dom/plugins/test/testplugin/nptest_windows.cpp:809 [C4838] conversion from 'LPARAM' to 'uintptr_t' requires a narrowing conversion
Updated•6 years ago
|
Component: IPC → Plug-ins
Reporter | ||
Comment 1•6 years ago
|
||
This is blocking roll-out of VS2015. I'll likely provide a workaround patch that adds -Wd4838 to CXXFLAGS. But I encourage the underlying problem to be fixed.
Reporter | ||
Comment 2•6 years ago
|
||
As part of unblocking building with VS2015u1 in automation, I'm mass disabling compiler warnings that are turned into errors. This is not the preferred mechanism to fix compilation warnings. So hopefully this patch never lands because someone insists of fixing the underlying problem instead. But if it does land, hopefully the workaround is only temporary. Review commit: https://reviewboard.mozilla.org/r/39847/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/39847/
Attachment #8730410 -
Flags: review?(aklotz)
Updated•6 years ago
|
Attachment #8730410 -
Flags: review?(aklotz) → review+
Comment 3•6 years ago
|
||
Comment on attachment 8730410 [details] MozReview Request: Bug 1256024 - Disable C4838 to unblock compilation on VS2015; r?aklotz https://reviewboard.mozilla.org/r/39847/#review36443 Makes sense.
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ea5cbcad14d3
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Updated•1 month ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•