1256029 - Several C5026 and C5027 move assignment|constructor was implicitly defined as deleted

Status: RESOLVED DUPLICATE of bug 1124033

(Core :: Security: PSM, defect)

Description

[Gregory Szorc [:gps]]

We are currently suppressing several new warnings in Visual Studio 2015. See bug 1124033 for more. When you stop suppressing them, the majority are C5026 and C5027 warnings in security/pkix. To reproduce the warnings, remove "-Wv:18" from old-configure.in and rebuild.

security/pkix/test/gtest/pkixbuild_tests.cpp:157 [C5026] 'TestTrustDomain': move constructor was implicitly defined as deleted
security/pkix/test/gtest/pkixbuild_tests.cpp:157 [C5027] 'TestTrustDomain': move assignment operator was implicitly defined as deleted
security/pkix/test/gtest/pkixbuild_tests.cpp:172 [C5027] 'pkixbuild': move assignment operator was implicitly defined as deleted
security/pkix/test/gtest/pkixbuild_tests.cpp:172 [C5026] 'pkixbuild': move constructor was implicitly defined as deleted
security/pkix/test/gtest/pkixbuild_tests.cpp:293 [C5027] 'ExpiredCertTrustDomain': move assignment operator was implicitly defined as deleted
security/pkix/test/gtest/pkixbuild_tests.cpp:293 [C5026] 'ExpiredCertTrustDomain': move constructor was implicitly defined as deleted
security/pkix/test/gtest/pkixbuild_tests.cpp:337 [C5026] 'DSSTrustDomain': move constructor was implicitly defined as deleted
security/pkix/test/gtest/pkixbuild_tests.cpp:337 [C5027] 'DSSTrustDomain': move assignment operator was implicitly defined as deleted
security/pkix/test/gtest/pkixbuild_tests.cpp:339 [C5027] 'pkixbuild_DSS': move assignment operator was implicitly defined as deleted
security/pkix/test/gtest/pkixbuild_tests.cpp:339 [C5026] 'pkixbuild_DSS': move constructor was implicitly defined as deleted
security/pkix/test/gtest/pkixbuild_tests.cpp:421 [C5027] 'IssuerNameCheckTrustDomain': move assignment operator was implicitly defined as deleted
security/pkix/test/gtest/pkixbuild_tests.cpp:421 [C5026] 'IssuerNameCheckTrustDomain': move constructor was implicitly defined as deleted
security/pkix/test/gtest/pkixbuild_tests.cpp:445 [C5027] 'pkixbunsCOMPtr.cpp
security/pkix/test/gtest/pkixbuild_tests.cpp:445 [C5026] 'pkixbuild_IssuerNameCheck': move constructor was implicitly defined as deleted
security/pkix/test/gtest/pkixcert_extension_tests.cpp:83 [C5026] 'TrustEverythingTrustDomain': move constructor was implicitly defined as deleted
security/pkix/test/gtest/pkixcert_extension_tests.cpp:83 [C5027] 'TrustEverythingTrustDomain': move assignment operator was implicitly defined as deleted
security/pkix/test/gtest/pkixcert_extension_tests.cpp:219 [C5027] 'pkixcert_extension': move assignment operator was implicitly defined as deleted
security/pkix/test/gtest/pkixcert_extension_tests.cpp:219 [C5026] 'pkixcert_extension': move constructor was implicitly defined as deleted
security/pkix/test/gtest/pkixcert_signature_algorithm_tests.cpp:109 [C5026] 'AlgorithmTestsTrustDomain': move constructor was implicitly defined as deleted
security/pkix/test/gtest/pkixcert_signature_algorithm_tests.cpp:109 [C5027] 'AlgorithmTestsTrustDomain': move assignment operator was implicitly defined as deleted
security/pkix/test/gtest/pkixcert_signature_algorithm_tests.cpp:187 [C5027] 'pkixcert_IsValidChainForAlgorithm': move assignment operator was implicitly defined as deleted
security/pkix/test/gtest/pkixcert_signature_algorithm_tests.cpp:187 [C5026] 'pkixcert_IsValidChainForAlgorithm': move constructor was implicitly defined as deleted
security/pkix/test/gtest/pkixcheck_CheckExtendedKeyUsage_tests.cpp:40 [C5026] 'pkixcheck_CheckExtendedKeyUsage': move constructor was implicitly defined as deleted
security/pkix/test/gtest/pkixcheck_CheckExtendedKeyUsage_tests.cpp:40 [C5027] 'pkixcheck_CheckExtendedKeyUsage': move assignment operator was implicitly defined as deleted
security/pkix/test/gtest/pkixcheck_CheckExtendedKeyUsage_tests.cpp:146 [C5026] 'CheckExtendedKeyUsageTest': move constructor was implicitly defined as deleted
security/pkix/test/gtest/pkixcheck_CheckExtendedKeyUsage_tests.cpp:146 [C5027] 'CheckExtendedKeyUsageTest': move assignment operator was implicitly defined as deleted
security/pkix/test/gtest/pkixcheck_CheckExtendedKeyUsage_tests.cpp:462 [C5027] 'CheckExtendedKeyUsageChainTest': move assignment operator was implicitly defined as deleted
security/pkix/test/gtest/pkixcheck_CheckExtendedKeyUsage_tests.cpp:462 [C5026] 'CheckExtendedKeyUsageChainTest': move constructor was implicitly defined as deleted
security/pkix/test/gtest/pkixcheck_CheckExtendedKeyUsage_tests.cpp:537 [C5027] 'EKUTrustDomain': move assignment operator was implicitly defined as deleted
security/pkix/test/gtest/pkixcheck_CheckExtendedKeyUsage_tests.cpp:537 [C5026] 'EKUTrustDomain': move constructor was implicitly defined as deleted
security/pkix/test/gtest/pkixcheck_CheckKeyUsage_tests.cpp:38 [C5027] 'pkixcheck_CheckKeyUsage': move assignment operator was implicitly defined as deleted
security/pkix/test/gtest/pkixcheck_CheckKeyUsage_tests.cpp:38 [C5026] 'pkixcheck_CheckKeyUsage': move constructor was implicitly defined as deleted
security/pkix/test/gtest/pkixcheck_CheckSignatureAlgorithm_tests.cpp:193 [C5027] 'pkixcheck_CheckSignatureAlgorithm': move assignment operator was implicitly defined as deleted
security/pkix/test/gtest/pkixcheck_CheckSignatureAlgorithm_tests.cpp:193 [C5026] 'pkixcheck_CheckSignatureAlgorithm': move constructor was implicitly defined as deleted
security/pkix/test/gtest/pkixcheck_CheckSignatureAlgorithm_tests.cpp:227 [C5027] 'pkixcheck_CheckSignatureAlgorithm_TrustDomain': move assignment operator was implicitly defined as deleted
security/pkix/test/gtest/pkixcheck_CheckSignatureAlgorithm_tests.cpp:227 [C5026] 'pkixcheck_CheckSignatureAlgorithm_TrustDomain': move constructor was implicitly defined as deleted
security/pkix/test/gtest/pkixcheck_CheckSignatureAlgorithm_tests.cpp:311 [C5026] 'pkixcheck_CheckSignatureAlgorithm_BuildCertChain_TrustDomain': move constructor was implicitly defined as deleted
security/pkix/test/gtest/pkixcheck_CheckSignatureAlgorithm_tests.cpp:311 [C5027] 'pkixcheck_CheckSignatureAlgorithm_BuildCertChain_TrustDomain': move assignment operator was implicitly defined as deleted
security/pkix/test/gtest/pkixcheck_CheckValidity_tests.cpp:57 [C5027] 'pkixcheck_CheckValidity': move assignment operator was implicitly defined as deleted
security/pkix/test/gtest/pkixcheck_CheckValidity_tests.cpp:57 [C5026] 'pkixcheck_CheckValidity': move constructor was implicitly defined as deleted
security/pkix/test/gtest/pkixcheck_ParseValidity_tests.cpp:43 [C5026] 'pkixcheck_ParseValidity': move constructor was implicitly defined as deleted
security/pkix/test/gtest/pkixcheck_ParseValidity_tests.cpp:43 [C5027] 'pkixcheck_ParseValidity': move assignment operator was implicitly defined as deleted
security/pkix/test/gtest/pkixcheck_TLSFeaturesSatisfiedInternal_tests.cpp:90 [C5027] 'pkixcheck_TLSFeaturesSatisfiedInternal': move assignment operator was implicitly defined as deleted
security/pkix/test/gtest/pkixcheck_TLSFeaturesSatisfiedInternal_tests.cpp:90 [C5026] 'pkixcheck_TLSFeaturesSatisfiedInternal': move constructor was implicitly defined as deleted
security/pkix/test/gtest/pkixder_input_tests.cpp:36 [C5027] '`anonymous-namespace'::pkixder_input_tests': move assignment operator was implicitly defined as deleted
security/pkix/test/gtest/pkixder_input_tests.cpp:36 [C5026] '`anonymous-namespace'::pkixder_input_tests': move constructor was implicitly defined as deleted
security/pkix/test/gtest/pkixder_pki_types_tests.cpp:35 [C5027] 'pkixder_pki_types_tests': move assignment operator was implicitly defined as deleted
security/pkix/test/gtest/pkixder_pki_types_tests.cpp:35 [C5026] 'pkixder_pki_types_tests': move constructor was implicitly defined as deleted
security/pkix/test/gtest/pkixder_pki_types_tests.cpp:208 [C5026] 'pkixder_DigestAlgorithmIdentifier_Valid': move constructor was implicitly defined as deleted
security/pkix/test/gtest/pkixder_pki_types_tests.cpp:208 [C5027] 'pkixder_DigestAlgorithmIdentifier_Valid': move assignment operator was implicitly defined as deleted
security/pkix/test/gtest/pkixder_pki_types_tests.cpp:274 [C5026] 'pkixder_DigestAlgorithmIdentifier_Invalid': move constructor was implicitly defined as deleted
security/pkix/test/gtest/pkixder_pki_types_tests.cpp:274 [C5027] 'pkixder_DigestAlgorithmIdentifier_Invalid': move assignment operator was implicitly defined as deleted
security/pkix/test/gtest/pkixder_pki_types_tests.cpp:383 [C5026] 'pkixder_SignatureAlgorithmIdentifierValue_Valid': move constructor was implicitly defined as deleted
security/pkix/test/gtest/pkixder_pki_types_tests.cpp:383 [C5027] 'pkixder_SignatureAlgorithmIdentifierValue_Valid': move assignment operator was implicitly defined as deleted
security/pkix/test/gtest/pkixder_pki_types_tests.cpp:461 [C5027] 'pkixder_SignatureAlgorithmIdentifier_Invalid': move assignment operator was implicitly defined as deleted
security/pkix/test/gtest/pkixder_pki_types_tests.cpp:461 [C5026] 'pkixder_SignatureAlgorithmIdentifier_Invalid': move constructor was implicitly defined as deleted
security/pkix/test/gtest/pkixder_universal_types_tests.cpp:37 [C5026] 'pkixder_universal_types_tests': move constructor was implicitly defined as deleted
security/pkix/test/gtest/pkixder_universal_types_tests.cpp:37 [C5027] 'pkixder_universal_types_tests': move assignment operator was implicitly defined as deleted
security/pkix/test/gtest/pkixder_universal_types_tests.cpp:910 [C5027] 'pkixder_universal_types_tests_Integer': move assignment operator was implicitly defined as deleted
security/pkix/test/gtest/pkixder_universal_types_tests.cpp:910 [C5026] 'pkixder_universal_types_tests_Integer': move constructor was implicitly defined as deleted
security/pkix/test/gtest/pkixgtest.h:173 [C5026] 'mozilla::pkix::test::EverythingFailsByDefaultTrustDomain': move constructor was implicitly defined as deleted
security/pkix/test/gtest/pkixgtest.h:173 [C5027] 'mozilla::pkix::test::EverythingFailsByDefaultTrustDomain': move assignment operator was implicitly defined as deleted
security/pkix/test/gtest/pkixgtest.h:217 [C5026] 'mozilla::pkix::test::DefaultCryptoTrustDomain': move constructor was implicitly defined as deleted
security/pkix/test/gtest/pkixgtest.h:217 [C5027] 'mozilla::pkix::test::DefaultCryptoTrustDomain': move assignment operator was implicitly defined as deleted
security/pkix/test/gtest/pkixnames_tests.cpp:905 [C5027] 'pkixnames_MatchPresentedDNSIDWithReferenceDNSID': move assignment operator was implicitly defined as deleted
security/pkix/test/gtest/pkixnames_tests.cpp:905 [C5026] 'pkixnames_MatchPresentedDNSIDWithReferenceDNSID': move constructor was implicitly defined as deleted
security/pkix/test/gtest/pkixnames_tests.cpp:940 [C5026] 'pkixnames_Turkish_I_Comparison': move constructor was implicitly defined as deleted
security/pkix/test/gtest/pkixnames_tests.cpp:940 [C5027] 'pkixnames_Turkish_I_Comparison': move assignment operator was implicitly defined as deleted
security/pkix/test/gtest/pkixnames_tests.cpp:985 [C5027] 'pkixnames_IsValidReferenceDNSID': move assignment operator was implicitly defined as deleted
security/pkix/test/gtest/pkixnames_tests.cpp:985 [C5026] 'pkixnames_IsValidReferenceDNSID': move constructor was implicitly defined as deleted
security/pkix/test/gtest/pkixnames_tests.cpp:1009 [C5026] 'pkixnames_ParseIPv4Address': move constructor was implicitly defined as deleted
security/pkix/test/gtest/pkixnames_tests.cpp:1009 [C5027] 'pkixnames_ParseIPv4Address': move assignment operator was implicitly defined as deleted
security/pkix/test/gtest/pkixnames_tests.cpp:1035 [C5027] 'pkixnames_ParseIPv6Address': move assignment operator was implicitly defined as deleted
security/pkix/test/gtest/pkixnames_tests.cpp:1035 [C5026] 'pkixnames_ParseIPv6Address': move constructor was implicitly defined as deleted
security/pkix/test/gtest/pkixnames_tests.cpp:1077 [C5027] 'pkixnames_CheckCertHostname': move assignment operator was implicitly defined as deleted
security/pkix/test/gtest/pkixnames_tests.cpp:1077 [C5026] 'pkixnames_CheckCertHostname': move constructor was implicitly defined as deleted
security/pkix/test/gtest/pkixnames_tests.cpp:1608 [C5027] 'pkixnames_CheckCertHostname_PresentedMatchesReference': move assignment operator was implicitly defined as deleted
security/pkix/test/gtest/pkixnames_tests.cpp:1715 [C5026] 'pkixnames_CheckCertHostname_IPV4_Addresses': move constructor was implicitly defined as deleted
security/pkix/test/gtest/pkixnames_tests.cpp:1715 [C5027] 'pkixnames_CheckCertHostname_IPV4_Addresses': move assignment operator was implicitly defined as deleted
security/pkix/test/gtest/pkixnames_tests.cpp:2513 [C5027] 'pkixnames_CheckNameConstraints': move assignment operator was implicitly defined as deleted
security/pkix/test/gtest/pkixnames_tests.cpp:2513 [C5026] 'pkixnames_CheckNameConstraints': move constructor was implicitly defined as deleted
security/pkix/test/gtest/pkixocsp_CreateEncodedOCSPRequest_tests.cpp:47 [C5026] 'CreateEncodedOCSPRequestTrustDomain': move constructor was implicitly defined as deleted
security/pkix/test/gtest/pkixocsp_CreateEncodedOCSPRequest_tests.cpp:47 [C5027] 'CreateEncodedOCSPRequestTrustDomain': move assignment operator was implicitly defined as deleted
security/pkix/test/gtest/pkixocsp_CreateEncodedOCSPRequest_tests.cpp:65 [C5026] 'pkixocsp_CreateEncodedOCSPRequest': move constructor was implicitly defined as deleted
security/pkix/test/gtest/pkixocsp_CreateEncodedOCSPRequest_tests.cpp:65 [C5027] 'pkixocsp_CreateEncodedOCSPRequest': move assignment operator was implicitly defined as deleted
security/pkix/test/gtest/pkixocsp_VerifyEncodedOCSPResponse.cpp:46 [C5027] 'OCSPTestTrustDomain': move assignment operator was implicitly defined as deleted
security/pkix/test/gtest/pkixocsp_VerifyEncodedOCSPResponse.cpp:46 [C5026] 'OCSPTestTrustDomain': move constructor was implicitly defined as deleted
security/pkix/test/gtest/pkixocsp_VerifyEncodedOCSPResponse.cpp:109 [C5027] 'pkixocsp_VerifyEncodedResponse': move assignment operator was implicitly defined as deleted
security/pkix/test/gtest/pkixocsp_VerifyEncodedOCSPResponse.cpp:109 [C5026] 'pkixocsp_VerifyEncodedResponse': move constructor was implicitly defined as deleted
security/pkix/test/gtest/pkixocsp_VerifyEncodedOCSPResponse.cpp:150 [C5027] 'pkixocsp_VerifyEncodedResponse_WithoutResponseBytes': move assignment operator was implicitly defined as deleted
security/pkix/test/gtest/pkixocsp_VerifyEncodedOCSPResponse.cpp:150 [C5026] 'pkixocsp_VerifyEncodedResponse_WithoutResponseBytes': move constructor was implicitly defined as deleted
security/pkix/test/gtest/pkixocsp_VerifyEncodedOCSPResponse.cpp:223 [C5026] 'pkixocsp_VerifyEncodedResponse_successful': move constructor was implicitly defined as deleted
security/pkix/test/gtest/pkixocsp_VerifyEncodedOCSPResponse.cpp:223 [C5027] 'pkixocsp_VerifyEncodedResponse_successful': move assignment operator was implicitly defined as deleted
security/pkix/test/gtest/pkixocsp_VerifyEncodedOCSPResponse.cpp:498 [C5027] 'pkixocsp_VerifyEncodedResponse_DelegatedResponder': move assignment operator was implicitly defined as deleted
security/pkix/test/gtest/pkixocsp_VerifyEncodedOCSPResponse.cpp:498 [C5026] 'pkixocsp_VerifyEncodedResponse_DelegatedResponder': move constructor was implicitly defined as deleted
security/pkix/test/gtest/pkixocsp_VerifyEncodedOCSPResponse.cpp:942 [C5026] 'pkixocsp_VerifyEncodedResponse_GetCertTrust::TrustDomain': moveUnified_cpp_image_test_gtest0.cpp
security/pkix/test/gtest/pkixocsp_VerifyEncodedOCSPResponse.cpp:942 [C5027] 'pkixocsp_VerifyEncodedResponse_GetCertTrust::TrustDomain': move assignment operator was implicitly defined as deleted
security/pkix/test/gtest/pkixocsp_VerifyEncodedOCSPResponse.cpp:948 [C5026] 'pkixocsp_VerifyEncodedResponse_GetCertTrust': move constructor was implicitly defined as deleted
security/pkix/test/gtest/pkixocsp_VerifyEncodedOCSPResponse.cpp:948 [C5027] 'pkixocsp_VerifyEncodedResponse_GetCertTrust': move assignment operator was implicitly defined as deleted
security/pkix/test/lib/pkixtestutil.h:437 [C5026] 'mozilla::pkix::test::OCSPResponseContext': move constructor was implicitly defined as deleted
security/pkix/test/lib/pkixtestutil.h:437 [C5027] 'mozilla::pkix::test::OCSPResponseContext': move assignment operator was implicitly defined as deleted

Comment 1

[Gregory Szorc [:gps]]

We decided to globally disable C5026 and C5027 instead.