1256085 - Australis Menu button (≡) doesn't look pressed in Customize mode if I use context menu in Australis Menu

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[arni2033]

>>>   My Info:   Win7_64, Nightly 48, 32bit, ID 20160312030405
STR_A:
1. Open http://example.org/ in a new tab
2. Click Australis Menu button (≡)
3. Right-click any item inside Australis Menu, e.g. "Customize" button.
4. Click "Customize..." / "Add More Items..." menuitem

AR:  After Step 4 button (≡) looks not pressed


STR_B:
1. Open http://example.org/ in a new tab
2. Click Australis Menu button (≡)
3. Click "Customize" button.
4. Right-click any toolbarbutton in Australis Menu or in Customization palette, click somewhere

AR:  After Step 3 button (≡) looks pressed. After Step 4 it looses "pressed" state.


ER:  Either X or Y
 X) Australis Menu button (≡) should always look pressed in Customize mode
 Y) Australis Menu button (≡) should always look NOT pressed in Customize mode

Comment 1

[:Gijs (he/him)]

Attachment: MozReview Request: Bug 1256085 - fix hamburger menu losing pressed state when a context menu inside the panel closes, r?jaws

Review commit: https://reviewboard.mozilla.org/r/40223/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/40223/

Comment 2

[:Gijs (he/him)]

Comment on attachment 8730913 [details]
MozReview Request: Bug 1256085 - fix hamburger menu losing pressed state when a context menu inside the panel closes, r?jaws

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40223/diff/1-2/

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8730913 [details]
MozReview Request: Bug 1256085 - fix hamburger menu losing pressed state when a context menu inside the panel closes, r?jaws

https://reviewboard.mozilla.org/r/40223/#review36803

Care to add a test for this?

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/bf91d8c73945

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/bf91d8c73945

Comment 6

[arni2033]

Fixed on:   Win7_64, Nightly 48, 32bit, ID 20160317030235

Comment 7

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 48.0a1 (2016-03-12) on Windows 7, 64 Bit!

This bug's fix is verified on latest Beta, Developer Edition and Nightly.

Build ID   20160714050942
User Agent Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:48.0) Gecko/20100101 Firefox/48.0


Build ID   20160727004019
User Agent Mozilla/5.0 (Windows NT 6.1; WOW64; rv:49.0) Gecko/20100101 Firefox/49.0


Build ID   20160714030208
User Agent Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:50.0) Gecko/20100101 Firefox/50.0