Keyboard swipe doesn't work on Galaxy S7

VERIFIED FIXED in Firefox 47

Status

()

defect
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: mkaply, Assigned: jchen)

Tracking

Trunk
Firefox 49
Points:
---

Firefox Tracking Flags

(firefox47 verified, firefox48 verified, firefox49 verified, fennec47+)

Details

Attachments

(6 attachments)

Reporter

Description

3 years ago
On my Galaxy S7, in many places in Firefox, using the Swype keyboard simply doesn't work. It also doesm't do autocomplete or anything like that.

This happens in bugzilla fields and places like the message fields here.

ttp://www.circuitoftheamericas.com/2016-f1
I am able to use Swype from the Play store. Blassey does this happen with your s6?
Flags: needinfo?(blassey.bugs)
Reporter

Comment 2

3 years ago
This is the built in swipe on the s7.

I am in Mountain View for the week if anyone here wants to see.
works for me on the s6
Flags: needinfo?(blassey.bugs)
Reporter

Comment 4

3 years ago
I do get the correct keyboard in the URL bar, I just don't get it for any entryfields/text areas on web pages.
Reporter

Comment 5

3 years ago
Posted file Log file
For this log, I started on bugzilla.mozilla.org.

I clicked in the input field and got the keyboard with no swipe or autopredict.

Then I clicked in the URL bar and got the regular keyboard.
Reporter

Updated

3 years ago
Attachment #8733036 - Attachment mime type: text/x-log → text/plain
This is a popular phone we should fix this.
tracking-fennec: --- → ?
Reporter

Comment 7

3 years ago
I'll be more than happy to try to debug this if someone can point me to the code that pops up the keyboard.
Assignee: nobody → nchen
tracking-fennec: ? → 47+
Jim, go ahead and get an S7 so you can figure this out
Status: NEW → ASSIGNED
Summary: Swipe keyboard doesn't work in many places → Keyboard swipe doesn't work on Galaxy S7
Showing and hiding the keyboard in onCreatInputConnection avoids a
possible race with resetInput in notifyIMEContext, and it replaces the
"show keyboard on window refocus" hack that we had before.
Attachment #8744356 - Flags: review?(esawin)
Make showSoftInput always post to the UI thread for consistency.
Attachment #8744357 - Flags: review?(esawin)
Initialize the EditorInfo object even when we return null in
onCreateInputConnection. This fixes the bug for the Samsung keyboard on
Galaxy S7.
Attachment #8744358 - Flags: review?(esawin)
Attachment #8744357 - Flags: review?(esawin) → review+
Attachment #8744358 - Flags: review?(esawin) → review+
Attachment #8744356 - Flags: review?(esawin) → review+

Comment 13

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3ef32a2ed627
https://hg.mozilla.org/mozilla-central/rev/9ee4cd959c96
https://hg.mozilla.org/mozilla-central/rev/7db5ba8edcfb
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Approval Request Comment
[Feature/regressing bug #]: N/A
[User impact if declined]: Cannot use the keyboard swipe feature on popular Galaxy S7 device
[Describe test coverage new/current, TreeHerder]: Locally
[Risks and why]: Very small; patch doesn't introduce any major behavior change
[String/UUID change made/needed]: None
Attachment #8745150 - Flags: review+
Attachment #8745150 - Flags: approval-mozilla-aurora?
Approval Request Comment
[Feature/regressing bug #]: N/A
[User impact if declined]: Cannot use the keyboard swipe feature on popular Galaxy S7 device
[Describe test coverage new/current, TreeHerder]: Locally
[Risks and why]: Very small; patch doesn't introduce any major behavior change
[String/UUID change made/needed]: None
Attachment #8745151 - Flags: review+
Attachment #8745151 - Flags: approval-mozilla-beta?
Comment on attachment 8745151 [details] [diff] [review]
Patch For Beta

Enables keyboard swipe feature on S7 device. Beta47+
Attachment #8745151 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment on attachment 8745150 [details] [diff] [review]
Patch for Aurora

Aurora48+
Attachment #8745150 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Reporter

Comment 20

3 years ago
I've verified that this is fixed when I build locally. Haven't tried any official builds yet. I'll mark verified once a beta has the fix.
Reproduced the issue on Firefox for Android 47 Beta 1 on Samsung Galaxy S7 Edge using Swipe from Samsung keyboard. 
Verified as fixed on Firefox for Android 47 Beta 2. Swipe works ok both on URL Bar and input fields.
Swipe works ok both on URL Bar and input fields:
Verified as fixed on:
Device: Samsung Galaxy S7 Edge (Android 6.0)
Build: Firefox for Android 49.0a1 and 48.0a2 (2016-05-03)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.