1256147 - Keyboard swipe doesn't work on Galaxy S7

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Keyboards and IME, defect)

Description

[Mike Kaply [:mkaply]]

On my Galaxy S7, in many places in Firefox, using the Swype keyboard simply doesn't work. It also doesm't do autocomplete or anything like that.

This happens in bugzilla fields and places like the message fields here.

ttp://www.circuitoftheamericas.com/2016-f1

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

I am able to use Swype from the Play store. Blassey does this happen with your s6?

Comment 2

[Mike Kaply [:mkaply]]

This is the built in swipe on the s7.

I am in Mountain View for the week if anyone here wants to see.

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

works for me on the s6

Comment 4

[Mike Kaply [:mkaply]]

I do get the correct keyboard in the URL bar, I just don't get it for any entryfields/text areas on web pages.

Comment 5

[Mike Kaply [:mkaply]]

Attachment: Log file

For this log, I started on bugzilla.mozilla.org.

I clicked in the input field and got the keyboard with no swipe or autopredict.

Then I clicked in the URL bar and got the regular keyboard.

Comment 6

[Kevin Brosnan [Ex-Mozilla]]

This is a popular phone we should fix this.

Comment 7

[Mike Kaply [:mkaply]]

I'll be more than happy to try to debug this if someone can point me to the code that pops up the keyboard.

Comment 8

[James Willcox (:snorp) ([e-mail]) (he/him)]

Jim, go ahead and get an S7 so you can figure this out

Comment 9

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Show/hide keyboard in onCreateInputConnection (v1)

Showing and hiding the keyboard in onCreatInputConnection avoids a
possible race with resetInput in notifyIMEContext, and it replaces the
"show keyboard on window refocus" hack that we had before.

Comment 10

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Post to UI thread for all showSoftInput calls (v1)

Make showSoftInput always post to the UI thread for consistency.

Comment 11

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Initialize EditorInfo even when IME is not active (v1)

Initialize the EditorInfo object even when we return null in
onCreateInputConnection. This fixes the bug for the Samsung keyboard on
Galaxy S7.

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3ef32a2ed627
https://hg.mozilla.org/integration/mozilla-inbound/rev/9ee4cd959c96
https://hg.mozilla.org/integration/mozilla-inbound/rev/7db5ba8edcfb

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3ef32a2ed627
https://hg.mozilla.org/mozilla-central/rev/9ee4cd959c96
https://hg.mozilla.org/mozilla-central/rev/7db5ba8edcfb

Comment 14

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Patch for Aurora

Approval Request Comment
[Feature/regressing bug #]: N/A
[User impact if declined]: Cannot use the keyboard swipe feature on popular Galaxy S7 device
[Describe test coverage new/current, TreeHerder]: Locally
[Risks and why]: Very small; patch doesn't introduce any major behavior change
[String/UUID change made/needed]: None

Comment 15

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Patch For Beta

Approval Request Comment
[Feature/regressing bug #]: N/A
[User impact if declined]: Cannot use the keyboard swipe feature on popular Galaxy S7 device
[Describe test coverage new/current, TreeHerder]: Locally
[Risks and why]: Very small; patch doesn't introduce any major behavior change
[String/UUID change made/needed]: None

Comment 16

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8745151 [details] [diff] [review]
Patch For Beta

Enables keyboard swipe feature on S7 device. Beta47+

Comment 17

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8745150 [details] [diff] [review]
Patch for Aurora

Aurora48+

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1a7240593dee67e2d5f3a4fc8df6123aaa533f60

Comment 19

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/362b8365615b

Comment 20

[Mike Kaply [:mkaply]]

I've verified that this is fixed when I build locally. Haven't tried any official builds yet. I'll mark verified once a beta has the fix.

Comment 21

[Teodora Vermesan (:TeoVermesan)]

Reproduced the issue on Firefox for Android 47 Beta 1 on Samsung Galaxy S7 Edge using Swipe from Samsung keyboard. 
Verified as fixed on Firefox for Android 47 Beta 2. Swipe works ok both on URL Bar and input fields.

Comment 22

[Teodora Vermesan (:TeoVermesan)]

Swipe works ok both on URL Bar and input fields:
Verified as fixed on:
Device: Samsung Galaxy S7 Edge (Android 6.0)
Build: Firefox for Android 49.0a1 and 48.0a2 (2016-05-03)