Closed
Bug 1256178
Opened 9 years ago
Closed 9 years ago
Drop the moz prefix from the MozCSSKeyframeRule and MozCSSKeyframesRule interfaces
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: ehsan.akhgari, Unassigned)
Details
(Keywords: dev-doc-complete, site-compat)
Attachments
(1 file)
16.43 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Comment 1•9 years ago
|
||
Attachment #8730019 -
Flags: review?(khuey)
Comment 2•9 years ago
|
||
I don't think we can suddenly replace the prefixed version with an unprefixed one.
Keywords: site-compat
Comment 3•9 years ago
|
||
What makes you say so? A quick search didn't bring up much more than http://www.cnblogs.com/chaojidan/p/4212925.html and a couple of copies, which all show `var ok = window.MozCSSKeyframeRule || window.WebKitCSSKeyframeRule || window.CSSKeyframeRule;`.
Comment 4•9 years ago
|
||
From past experience. For example, when I tried to drop -moz-gradients, we found Google(!) sniffed us and sent only -moz-prefixed gradients.
Reporter | ||
Comment 5•9 years ago
|
||
FWIW I did a search on github and also the add-ons MXR before submitting this patch to see if these prefixed names are being widely used and they don't seem to.
Attachment #8730019 -
Flags: review?(khuey) → review?(bzbarsky)
Updated•9 years ago
|
Keywords: dev-doc-needed
Comment 6•9 years ago
|
||
Comment on attachment 8730019 [details] [diff] [review]
Drop the moz prefix from the MozCSSKeyframeRule and MozCSSKeyframesRule interfaces
This isn't even on webidl yet, ick.
r=me; I doubt anyone depends on this naming, since these are not constructible.
Attachment #8730019 -
Flags: review?(bzbarsky) → review+
Comment 8•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Comment 9•9 years ago
|
||
Posted the site compatibility doc: https://www.fxsitecompat.com/en-CA/docs/2016/csskeyframerule-and-csskeyframesrule-have-been-unprefixed/
Reporter | ||
Comment 10•9 years ago
|
||
Thanks, Kohei!
Comment 11•9 years ago
|
||
Documentation updated:
https://developer.mozilla.org/en-US/docs/Web/API/CSSKeyframeRule
https://developer.mozilla.org/en-US/docs/Web/API/CSSKeyframesRule
Mentioned on Firefox 48 for developers (someone got there before me). But I did linkify them there and fix some other stuff, so yay me!
Keywords: dev-doc-needed → dev-doc-complete
Comment 12•9 years ago
|
||
Sheppy: we don't list the webidl in interfaces (we link to them in the spec link anyway). Can you remove them? Thank you.
Keywords: dev-doc-complete → dev-doc-needed
Comment 13•9 years ago
|
||
I've removed the 'Syntax' sections from the two pages.
Sebastian
Keywords: dev-doc-needed → dev-doc-complete
Assignee | ||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•