Remove magical Talos g2 enabling code that isn't needed anymore

RESOLVED FIXED

Status

RESOLVED FIXED
3 years ago
4 months ago

People

(Reporter: RyanVM, Assigned: RyanVM)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
mozilla-tests/config.py has a block of code for enabling Talos g2 unconditionally on Gecko 40+. At this point, all Talos-running branches are already newer than version 40, so this block is at best a no-op and at worst actually causes Talos jobs to be scheduled on branches that otherwise wouldn't run any Talos tests.

That's actually how I found this bug - I'm working on getting Ash ready for e10s testing and was finding that g2 was somehow getting enabled even though I was explicitly setting "'enable_talos': False" in project_branches.py.
(Assignee)

Comment 1

3 years ago
Created attachment 8730029 [details] [diff] [review]
patch

Looks like Oak was special too :)

Builders removed
- Rev7 MacOSX Yosemite 10.10.5 oak talos g2
- Ubuntu HW 12.04 x64 oak pgo talos g2
- Ubuntu HW 12.04 x64 oak talos g2
- Windows 7 32-bit oak pgo talos g2
- Windows 7 32-bit oak talos g2
- Windows 8 64-bit oak pgo talos g2
- Windows 8 64-bit oak talos g2
- Windows XP 32-bit oak pgo talos g2
- Windows XP 32-bit oak talos g2
Attachment #8730029 - Flags: review?(jmaher)
(Assignee)

Comment 2

3 years ago
Created attachment 8730031 [details] [diff] [review]
patch

Whoops, attached the test patch instead of the actual one.
Attachment #8730029 - Attachment is obsolete: true
Attachment #8730029 - Flags: review?(jmaher)
Attachment #8730031 - Flags: review?(jmaher)
Comment on attachment 8730031 [details] [diff] [review]
patch

Review of attachment 8730031 [details] [diff] [review]:
-----------------------------------------------------------------

good find.  I think we could clean up another 500 lines in that file if we were so inclined :)
Attachment #8730031 - Flags: review?(jmaher) → review+
(Assignee)

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Component: General Automation → General
Product: Release Engineering → Release Engineering
You need to log in before you can comment on or make changes to this bug.