1256210 - convert test_additional_sheets.html to be runnable with e10s enabled

Status: RESOLVED FIXED

(Core :: DOM: CSS Object Model, defect)

Description

[Cameron McCormack (:heycam)]

This tests nsIStyleSheetService.{loadAndRegisterSheet,unregisterSheet}, which behave differently if called in the parent or content process, so we should convert it to a test that can run with e10s enabled to exercise both paths.

Comment 1

[Cameron McCormack (:heycam)]

Attachment: MozReview Request: Bug 1256210 - Part 1: Factor out getting of services in test_additional_sheets.html. r=dbaron

Review commit: https://reviewboard.mozilla.org/r/39661/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39661/

Comment 2

[Cameron McCormack (:heycam)]

Attachment: MozReview Request: Bug 1256210 - Part 2: Convert test_additional_sheets.html and test_addSheets.html to mochitest-plain. r?dbaron

Review commit: https://reviewboard.mozilla.org/r/39663/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39663/

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 8730100 [details]
MozReview Request: Bug 1256210 - Part 1: Factor out getting of services in test_additional_sheets.html. r=dbaron

https://reviewboard.mozilla.org/r/39661/#review36453

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 8730101 [details]
MozReview Request: Bug 1256210 - Part 2: Convert test_additional_sheets.html and test_addSheets.html to mochitest-plain. r?dbaron

https://reviewboard.mozilla.org/r/39663/#review36455

This seems fine, except layout/style/test/chrome/test_addSheet.html also uses additional_sheets_helper.html, so I think you need to deal with that at the same time, no?

Comment 5

[Cameron McCormack (:heycam)]

(In reply to David Baron [:dbaron] ⌚️UTC-7 from comment #4)
> This seems fine, except layout/style/test/chrome/test_addSheet.html also
> uses additional_sheets_helper.html, so I think you need to deal with that at
> the same time, no?

I didn't notice.  I may as well convert test_addSheet.html to mochitest-plain too.

Comment 6

[Cameron McCormack (:heycam)]

Comment on attachment 8730100 [details]
MozReview Request: Bug 1256210 - Part 1: Factor out getting of services in test_additional_sheets.html. r=dbaron

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/39661/diff/1-2/

Comment 7

[Cameron McCormack (:heycam)]

Comment on attachment 8730101 [details]
MozReview Request: Bug 1256210 - Part 2: Convert test_additional_sheets.html and test_addSheets.html to mochitest-plain. r?dbaron

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/39663/diff/1-2/

Comment 8

[Cameron McCormack (:heycam)]

(I guess git didn't feel like test_addSheets.html was similar enough after moving that it was the same file.)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d6864a602cd1

Comment 9

[Cameron McCormack (:heycam)]

Comment on attachment 8730100 [details]
MozReview Request: Bug 1256210 - Part 1: Factor out getting of services in test_additional_sheets.html. r=dbaron

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/39661/diff/2-3/

Comment 10

[Cameron McCormack (:heycam)]

Comment on attachment 8730101 [details]
MozReview Request: Bug 1256210 - Part 2: Convert test_additional_sheets.html and test_addSheets.html to mochitest-plain. r?dbaron

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/39663/diff/2-3/

Comment 11

[Cameron McCormack (:heycam)]

Attachment: MozReview Request: Bug 1256210 - Part 3: Remove agent sheet by the end of test_additional_sheets.html. r?dbaron

Review commit: https://reviewboard.mozilla.org/r/40029/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/40029/

Comment 12

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=96a33c85765e

Comment 13

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 8730101 [details]
MozReview Request: Bug 1256210 - Part 2: Convert test_additional_sheets.html and test_addSheets.html to mochitest-plain. r?dbaron

https://reviewboard.mozilla.org/r/39663/#review37129

Please land in Mercurial in a way that gets the file move metadata correct, which may mean not using your normal git->mercurial workflow, given that git seems to have misunderstood the move.

Comment 14

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 8730583 [details]
MozReview Request: Bug 1256210 - Part 3: Remove agent sheet by the end of test_additional_sheets.html. r?dbaron

https://reviewboard.mozilla.org/r/40029/#review37131

Maybe put the result of getStyle in a variable rather than calling it twice?

Comment 15

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/81cc69f9295f
https://hg.mozilla.org/integration/mozilla-inbound/rev/5d01a67037fb
https://hg.mozilla.org/integration/mozilla-inbound/rev/a07bf6b78039

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/81cc69f9295f
https://hg.mozilla.org/mozilla-central/rev/5d01a67037fb
https://hg.mozilla.org/mozilla-central/rev/a07bf6b78039