Closed Bug 1256210 Opened 8 years ago Closed 8 years ago

convert test_additional_sheets.html to be runnable with e10s enabled

Categories

(Core :: DOM: CSS Object Model, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
e10s + ---
firefox48 --- fixed

People

(Reporter: heycam, Unassigned)

References

(Blocks 2 open bugs)

Details

Attachments

(3 files)

This tests nsIStyleSheetService.{loadAndRegisterSheet,unregisterSheet}, which behave differently if called in the parent or content process, so we should convert it to a test that can run with e10s enabled to exercise both paths.
Comment on attachment 8730100 [details]
MozReview Request: Bug 1256210 - Part 1: Factor out getting of services in test_additional_sheets.html. r=dbaron

https://reviewboard.mozilla.org/r/39661/#review36453
Attachment #8730100 - Flags: review?(dbaron) → review+
Comment on attachment 8730101 [details]
MozReview Request: Bug 1256210 - Part 2: Convert test_additional_sheets.html and test_addSheets.html to mochitest-plain. r?dbaron

https://reviewboard.mozilla.org/r/39663/#review36455

This seems fine, except layout/style/test/chrome/test_addSheet.html also uses additional_sheets_helper.html, so I think you need to deal with that at the same time, no?
Attachment #8730101 - Flags: review?(dbaron)
(In reply to David Baron [:dbaron] ⌚️UTC-7 from comment #4)
> This seems fine, except layout/style/test/chrome/test_addSheet.html also
> uses additional_sheets_helper.html, so I think you need to deal with that at
> the same time, no?

I didn't notice.  I may as well convert test_addSheet.html to mochitest-plain too.
Comment on attachment 8730100 [details]
MozReview Request: Bug 1256210 - Part 1: Factor out getting of services in test_additional_sheets.html. r=dbaron

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/39661/diff/1-2/
Attachment #8730100 - Attachment description: MozReview Request: Bug 1256210 - Part 1: Factor out getting of services in test_additional_sheets.html. r?dbaron → MozReview Request: Bug 1256210 - Part 1: Factor out getting of services in test_additional_sheets.html. r=dbaron
Attachment #8730101 - Attachment description: MozReview Request: Bug 1256210 - Part 2: Convert test_additional_sheets.html to a mochitest-plain. r?dbaron → MozReview Request: Bug 1256210 - Part 2: Convert test_additional_sheets.html and test_addSheets.html to mochitest-plain. r?dbaron
Attachment #8730101 - Flags: review?(dbaron)
Comment on attachment 8730101 [details]
MozReview Request: Bug 1256210 - Part 2: Convert test_additional_sheets.html and test_addSheets.html to mochitest-plain. r?dbaron

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/39663/diff/1-2/
(I guess git didn't feel like test_addSheets.html was similar enough after moving that it was the same file.)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d6864a602cd1
Comment on attachment 8730100 [details]
MozReview Request: Bug 1256210 - Part 1: Factor out getting of services in test_additional_sheets.html. r=dbaron

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/39661/diff/2-3/
Comment on attachment 8730101 [details]
MozReview Request: Bug 1256210 - Part 2: Convert test_additional_sheets.html and test_addSheets.html to mochitest-plain. r?dbaron

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/39663/diff/2-3/
Comment on attachment 8730101 [details]
MozReview Request: Bug 1256210 - Part 2: Convert test_additional_sheets.html and test_addSheets.html to mochitest-plain. r?dbaron

https://reviewboard.mozilla.org/r/39663/#review37129

Please land in Mercurial in a way that gets the file move metadata correct, which may mean not using your normal git->mercurial workflow, given that git seems to have misunderstood the move.
Attachment #8730101 - Flags: review?(dbaron) → review+
Comment on attachment 8730583 [details]
MozReview Request: Bug 1256210 - Part 3: Remove agent sheet by the end of test_additional_sheets.html. r?dbaron

https://reviewboard.mozilla.org/r/40029/#review37131

Maybe put the result of getStyle in a variable rather than calling it twice?
Attachment #8730583 - Flags: review?(dbaron) → review+
You need to log in before you can comment on or make changes to this bug.